staticaddr: fractional swap amount #887
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieblmi
force-pushed
the
static-arb-amount-swap
branch
3 times, most recently
from
fd6cc75 to
f54115f
Compare
hieblmi
force-pushed
the
static-arb-amount-swap
branch
from
f54115f to
d2bdd44
Compare
hieblmi
force-pushed
the
static-arb-amount-swap
branch
2 times, most recently
from
df64647 to
358ab53
Compare
hieblmi
force-pushed
the
static-arb-amount-swap
branch
from
358ab53 to
12f6107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
amountflag to static loop-in swaps that allows the caller to only swap a fraction of the value of the selected deposits.To ensure backwards UX compatibility, omitting the new flag (
--amount=0) selects the total deposit amount for swapping.TODO