Review part 3

linera-io · Feb 20, 2025 · b79881f · b79881f
1 parent c51e2c3
commit b79881f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/linera-base/src/crypto/ed25519.rs b/linera-base/src/crypto/ed25519.rs
@@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
 
 use super::{
     le_bytes_to_u64_array, u64_array_to_le_bytes, BcsHashable, BcsSignable, CryptoError,
-    CryptoHash, HasTypeName, Hashable, ValidatorPublicKey, ValidatorSignature,
+    CryptoHash, HasTypeName, Hashable,
 };
 use crate::{doc_scalar, identifiers::Owner};
 
@@ -330,7 +330,7 @@ impl Ed25519Signature {
     pub fn verify_batch<'a, 'de, T, I>(value: &'a T, votes: I) -> Result<(), CryptoError>
     where
         T: BcsSignable<'de>,
-        I: IntoIterator<Item = (&'a ValidatorPublicKey, &'a ValidatorSignature)>,
+        I: IntoIterator<Item = (&'a Ed25519PublicKey, &'a Ed25519Signature)>,
     {
         Ed25519Signature::verify_batch_internal(value, votes).map_err(|error| {
             CryptoError::InvalidSignature {

diff --git a/linera-chain/src/unit_tests/data_types_tests.rs b/linera-chain/src/unit_tests/data_types_tests.rs
@@ -84,10 +84,8 @@ fn test_certificates() {
     let key1 = ValidatorSecretKey::generate();
     let key2 = ValidatorSecretKey::generate();
     let key3 = ValidatorSecretKey::generate();
-    let validator1_pk = key1.public();
-    let validator2_pk = key2.public();
 
-    let committee = Committee::make_simple(vec![validator1_pk, validator2_pk]);
+    let committee = Committee::make_simple(vec![key1.public(), key2.public()]);
 
     let block =
         make_first_block(ChainId::root(1)).with_simple_transfer(ChainId::root(1), Amount::ONE);