Remove max_in_flight from linera benchmark (#3235)

## Motivation

We're gonna slowly change the design of this. Limiting the amount of in flight requests goes against our goal of stress testing a network with this

## Proposal

Remove that constraint

## Test Plan

Ran `linera benchmark` with a few parameter variations

## Release Plan

- Nothing to do / These changes follow the usual release cycle.

.github/workflows/rust.yml

@@ -140,7 +140,7 @@ jobs:
 
   benchmark-test:
     runs-on: ubuntu-latest
-    timeout-minutes: 20
+    timeout-minutes: 30
 
     steps:
     - uses: actions/checkout@v3

linera-client/src/client_context.rs

@@ -25,9 +25,18 @@ use linera_rpc::node_provider::{NodeOptions, NodeProvider};
 use linera_storage::Storage;
 use thiserror_context::Context;
 use tracing::{debug, info};
+#[cfg(feature = "fs")]
+use {
+    linera_base::{
+        crypto::CryptoHash,
+        data_types::{BlobContent, Bytecode},
+        identifiers::BytecodeId,
+    },
+    linera_core::client::create_bytecode_blobs,
+    std::{fs, path::PathBuf},
+};
 #[cfg(feature = "benchmark")]
 use {
-    futures::{stream, StreamExt as _, TryStreamExt as _},
     linera_base::{
         crypto::PublicKey,
         data_types::Amount,
@@ -52,16 +61,6 @@ use {
     tokio::task,
     tracing::{error, trace},
 };
-#[cfg(feature = "fs")]
-use {
-    linera_base::{
-        crypto::CryptoHash,
-        data_types::{BlobContent, Bytecode},
-        identifiers::BytecodeId,
-    },
-    linera_core::client::create_bytecode_blobs,
-    std::{fs, path::PathBuf},
-};
 
 #[cfg(web)]
 use crate::persistent::{LocalPersist as Persist, LocalPersistExt as _};
@@ -665,7 +664,6 @@ where
         &mut self,
         key_pairs: &HashMap<ChainId, KeyPair>,
         application_id: ApplicationId,
-        max_in_flight: usize,
     ) -> Result<(), Error> {
         let default_chain_id = self
             .wallet
@@ -702,38 +700,35 @@ where
         }
         self.update_wallet_from_client(&chain_client).await?;
         // Make sure all chains have registered the application now.
-        let futures = key_pairs
-            .keys()
-            .map(|&chain_id| {
-                let chain_client = self
-                    .make_chain_client(chain_id)
-                    .expect("chain should have been created");
-                async move {
-                    for i in 0..5 {
-                        linera_base::time::timer::sleep(Duration::from_secs(i)).await;
-                        chain_client.process_inbox().await?;
-                        let chain_state = chain_client.chain_state_view().await?;
-                        if chain_state
-                            .execution_state
-                            .system
-                            .registry
-                            .known_applications
-                            .contains_key(&application_id)
-                            .await?
-                        {
-                            return Ok::<_, Error>(chain_client);
-                        }
+        let mut join_set = task::JoinSet::new();
+        for &chain_id in key_pairs.keys() {
+            let chain_client = self
+                .make_chain_client(chain_id)
+                .expect("chain should have been created");
+            join_set.spawn(async move {
+                for i in 0..5 {
+                    linera_base::time::timer::sleep(Duration::from_secs(i)).await;
+                    chain_client.process_inbox().await?;
+                    let chain_state = chain_client.chain_state_view().await?;
+                    if chain_state
+                        .execution_state
+                        .system
+                        .registry
+                        .known_applications
+                        .contains_key(&application_id)
+                        .await?
+                    {
+                        return Ok::<_, Error>(chain_client);
                     }
-                    panic!("Could not instantiate application on chain {chain_id:?}");
                 }
-            })
-            .collect::<Vec<_>>();
-        // We have to collect the futures to avoid a higher-ranked lifetime error:
-        // https://github.com/rust-lang/rust/issues/102211#issuecomment-1673201352
-        let clients = stream::iter(futures)
-            .buffer_unordered(max_in_flight)
-            .try_collect::<Vec<_>>()
-            .await?;
+                panic!("Could not instantiate application on chain {chain_id:?}");
+            });
+        }
+        let clients = join_set
+            .join_all()
+            .await
+            .into_iter()
+            .collect::<Result<Vec<_>, _>>()?;
         for client in clients {
             self.update_wallet_from_client(&client).await?;
         }
@@ -843,7 +838,6 @@ where
     pub async fn mass_broadcast(
         &self,
         phase: &'static str,
-        max_in_flight: usize,
         proposals: Vec<RpcMessage>,
     ) -> Vec<RpcMessage> {
         let time_start = Instant::now();
@@ -853,10 +847,7 @@ where
             let proposals = proposals.clone();
             join_set.spawn(async move {
                 debug!("Sending {} requests", proposals.len());
-                let responses = client
-                    .send(proposals, max_in_flight)
-                    .await
-                    .unwrap_or_default();
+                let responses = client.send(proposals).await.unwrap_or_default();
                 debug!("Done sending requests");
                 responses
             });

linera-client/src/client_options.rs

@@ -585,10 +585,6 @@ pub enum ClientCommand {
     /// Send one transfer per chain in bulk mode
     #[cfg(feature = "benchmark")]
     Benchmark {
-        /// Maximum number of blocks in flight
-        #[arg(long, default_value = "200")]
-        max_in_flight: usize,
-
         /// How many chains to use for the benchmark
         #[arg(long, default_value = "10")]
         num_chains: usize,

linera-rpc/src/grpc/client.rs

@@ -463,60 +463,60 @@ impl mass_client::MassClient for GrpcClient {
     async fn send(
         &self,
         requests: Vec<RpcMessage>,
-        max_in_flight: usize,
     ) -> Result<Vec<RpcMessage>, mass_client::MassClientError> {
         let client = self.client.clone();
-        let responses = stream::iter(requests)
-            .map(|request| {
-                let mut client = client.clone();
-                async move {
-                    let response = match request {
-                        RpcMessage::BlockProposal(proposal) => {
-                            let request = Request::new((*proposal).try_into()?);
-                            client.handle_block_proposal(request).await?
-                        }
-                        RpcMessage::TimeoutCertificate(request) => {
-                            let request = Request::new((*request).try_into()?);
-                            client.handle_timeout_certificate(request).await?
-                        }
-                        RpcMessage::ValidatedCertificate(request) => {
-                            let request = Request::new((*request).try_into()?);
-                            client.handle_validated_certificate(request).await?
-                        }
-                        RpcMessage::ConfirmedCertificate(request) => {
-                            let request = Request::new((*request).try_into()?);
-                            client.handle_confirmed_certificate(request).await?
-                        }
-                        msg => panic!("attempted to send msg: {:?}", msg),
-                    };
-                    match response
-                        .into_inner()
-                        .inner
-                        .ok_or(GrpcProtoConversionError::MissingField)?
-                    {
-                        api::chain_info_result::Inner::ChainInfoResponse(chain_info_response) => {
-                            Ok(Some(RpcMessage::ChainInfoResponse(Box::new(
-                                chain_info_response.try_into()?,
-                            ))))
-                        }
-                        api::chain_info_result::Inner::Error(error) => {
-                            let error = bincode::deserialize::<NodeError>(&error)
-                                .map_err(GrpcProtoConversionError::BincodeError)?;
-                            tracing::error!(?error, "received error response");
-                            Ok(None)
-                        }
+        let mut join_set: tokio::task::JoinSet<
+            Result<Option<RpcMessage>, mass_client::MassClientError>,
+        > = tokio::task::JoinSet::new();
+
+        // Spawn tasks for each request
+        for request in requests {
+            let mut client = client.clone();
+            join_set.spawn(async move {
+                let response = match request {
+                    RpcMessage::BlockProposal(proposal) => {
+                        let request = Request::new((*proposal).try_into()?);
+                        client.handle_block_proposal(request).await?
+                    }
+                    RpcMessage::TimeoutCertificate(request) => {
+                        let request = Request::new((*request).try_into()?);
+                        client.handle_timeout_certificate(request).await?
+                    }
+                    RpcMessage::ValidatedCertificate(request) => {
+                        let request = Request::new((*request).try_into()?);
+                        client.handle_validated_certificate(request).await?
+                    }
+                    RpcMessage::ConfirmedCertificate(request) => {
+                        let request = Request::new((*request).try_into()?);
+                        client.handle_confirmed_certificate(request).await?
+                    }
+                    msg => panic!("attempted to send msg: {:?}", msg),
+                };
+                match response
+                    .into_inner()
+                    .inner
+                    .ok_or(GrpcProtoConversionError::MissingField)?
+                {
+                    api::chain_info_result::Inner::ChainInfoResponse(chain_info_response) => {
+                        Ok(Some(RpcMessage::ChainInfoResponse(Box::new(
+                            chain_info_response.try_into()?,
+                        ))))
+                    }
+                    api::chain_info_result::Inner::Error(error) => {
+                        let error = bincode::deserialize::<NodeError>(&error)
+                            .map_err(GrpcProtoConversionError::BincodeError)?;
+                        tracing::error!(?error, "received error response");
+                        Ok(None)
                     }
                 }
-            })
-            .buffer_unordered(max_in_flight)
-            .filter_map(
-                |result: Result<Option<_>, mass_client::MassClientError>| async move {
-                    result.transpose()
-                },
-            )
-            .collect::<Vec<_>>()
+            });
+        }
+
+        let responses = join_set
+            .join_all()
             .await
             .into_iter()
+            .filter_map(|result| result.transpose())
             .collect::<Result<Vec<_>, _>>()?;
         Ok(responses)
     }

linera-rpc/src/mass_client.rs

@@ -20,9 +20,5 @@ pub enum MassClientError {
 
 #[async_trait]
 pub trait MassClient {
-    async fn send(
-        &self,
-        requests: Vec<RpcMessage>,
-        max_in_flight: usize,
-    ) -> Result<Vec<RpcMessage>, MassClientError>;
+    async fn send(&self, requests: Vec<RpcMessage>) -> Result<Vec<RpcMessage>, MassClientError>;
 }

linera-rpc/src/simple/client.rs

@@ -259,7 +259,6 @@ impl mass_client::MassClient for SimpleMassClient {
     async fn send(
         &self,
         requests: Vec<RpcMessage>,
-        max_in_flight: usize,
     ) -> Result<Vec<RpcMessage>, mass_client::MassClientError> {
         let address = format!("{}:{}", self.network.host, self.network.port);
         let mut stream = self.network.protocol.connect(address).await?;
@@ -268,7 +267,7 @@ impl mass_client::MassClient for SimpleMassClient {
         let mut responses = Vec::new();
 
         loop {
-            while in_flight < max_in_flight {
+            loop {
                 let request = match requests.next() {
                     None => {
                         if in_flight == 0 {

linera-service/src/cli_wrappers/wallet.rs

@@ -679,7 +679,6 @@ impl ClientWrapper {
     #[cfg(feature = "benchmark")]
     pub async fn benchmark(
         &self,
-        max_in_flight: usize,
         num_chains: usize,
         transactions_per_block: usize,
         fungible_application_id: Option<
@@ -689,7 +688,6 @@ impl ClientWrapper {
         let mut command = self.command().await?;
         command
             .arg("benchmark")
-            .args(["--max-in-flight", &max_in_flight.to_string()])
             .args(["--num-chains", &num_chains.to_string()])
             .args([
                 "--transactions-per-block",

linera-service/src/linera/main.rs

@@ -759,7 +759,6 @@ impl Runnable for Job {
 
             #[cfg(feature = "benchmark")]
             Benchmark {
-                max_in_flight,
                 num_chains,
                 tokens_per_chain,
                 transactions_per_block,
@@ -775,9 +774,7 @@ impl Runnable for Job {
                     .await?;
 
                 if let Some(id) = fungible_application_id {
-                    context
-                        .supply_fungible_tokens(&key_pairs, id, max_in_flight)
-                        .await?;
+                    context.supply_fungible_tokens(&key_pairs, id).await?;
                 }
 
                 // For this command, we create proposals and gather certificates without using
@@ -801,9 +798,7 @@ impl Runnable for Job {
                     }
                 }
 
-                let responses = context
-                    .mass_broadcast("block proposals", max_in_flight, proposals)
-                    .await;
+                let responses = context.mass_broadcast("block proposals", proposals).await;
                 let votes = responses
                     .into_iter()
                     .filter_map(|message| {
@@ -833,9 +828,7 @@ impl Runnable for Job {
                         ))
                     })
                     .collect();
-                let responses = context
-                    .mass_broadcast("certificates", max_in_flight, messages)
-                    .await;
+                let responses = context.mass_broadcast("certificates", messages).await;
                 let mut confirmed = HashSet::new();
                 let num_valid = responses.into_iter().fold(0, |acc, message| {
                     match deserialize_response(message) {

linera-service/tests/local_net_tests.rs

@@ -819,7 +819,7 @@ async fn test_end_to_end_benchmark(mut config: LocalNetConfig) -> Result<()> {
 
     assert_eq!(client.load_wallet()?.num_chains(), 3);
     // Launch local benchmark using some additional chains.
-    client.benchmark(2, 4, 10, None).await?;
+    client.benchmark(4, 10, None).await?;
     assert_eq!(client.load_wallet()?.num_chains(), 7);
 
     // Now we run the benchmark again, with the fungible token application instead of the
@@ -839,7 +839,7 @@ async fn test_end_to_end_benchmark(mut config: LocalNetConfig) -> Result<()> {
             None,
         )
         .await?;
-    client.benchmark(2, 5, 10, Some(application_id)).await?;
+    client.benchmark(5, 10, Some(application_id)).await?;
 
     net.ensure_is_running().await?;
     net.terminate().await?;