GRPC entrypoint to download a blob #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andresilva91 and the rest of your teammates on |
Merged
ndr-ds
force-pushed
the
05-15-grpc_entrypoint_to_download_a_blob
branch
from
2a775f9 to
8448c6e
Compare
ma2bd
reviewed
May 18, 2024
ndr-ds
force-pushed
the
05-08-publishblob
branch
2 times, most recently
from
a5ab0fe to
1b2def3
Compare
ndr-ds
force-pushed
the
05-15-grpc_entrypoint_to_download_a_blob
branch
from
8448c6e to
81193df
Compare
ndr-ds
force-pushed
the
05-15-grpc_entrypoint_to_download_a_blob
branch
3 times, most recently
from
c53bd85 to
88a86ba
Compare
graphite-app
bot
requested review from
Twey,
MathieuDutSik,
jvff,
christos-h,
afck and
ma2bd
and removed request for
MathieuDutSik,
jvff and
christos-h
Graphite Automations"Assign reviewers" took an action on this PR • (05/28/24)6 reviewers were added to this PR based on Andre da Silva's automation. |
afck
reviewed
May 28, 2024
afck
approved these changes
May 28, 2024
ndr-ds
force-pushed
the
05-15-grpc_entrypoint_to_download_a_blob
branch
2 times, most recently
from
6aed766 to
b6c9738
Compare
ma2bd
reviewed
May 28, 2024
ndr-ds
force-pushed
the
05-15-grpc_entrypoint_to_download_a_blob
branch
from
b6c9738 to
8f3cd5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to be able to download blobs directly from the Proxy as part of the user blobs work. Fixes #2028
Proposal
This PR does a few things:
Test Plan
WIP