Remove the RocksDb option in Database.
#2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
reviewed
Sep 16, 2024
MathieuDutSik
force-pushed
the
database_rocksdb
branch
from
566e957 to
d412540
Compare
afck
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
RocksDboption ofDatabasecannot be used since thestorageis used by the proxy and by the validators, so even in the case of just one worker, the RocksDb would be shared between two programs and that is not possible.Proposal
Remove the
RocksDbfrom theDatabaseand the relevant code.Test Plan
CI
Release Plan
Not relevant.
Links