Wasm threading #2517
Merged
Wasm threading #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
wasm-thread
branch
4 times, most recently
from
cd11041 to
dab8d3e
Compare
Use the `wasm_thread` library to enable real `spawn_blocking` on the Web in `linera_base::task`.
afck
approved these changes
Sep 23, 2024
| @@ -159,7 +162,7 @@ jobs: | |||
| | xargs -0 scripts/target/release/check_copyright_header | |||
| - name: Put lint toolchain file in place | |||
| run: | | |||
| ln -sf toolchains/lint/rust-toolchain.toml | |||
| ln -sf toolchains/nightly/rust-toolchain.toml | |||
There was a problem hiding this comment.
Is this line still needed at all then?
There was a problem hiding this comment.
Yes, we're still using the stable toolchain by default.
christos-h
approved these changes
Sep 23, 2024
ma2bd
reviewed
Sep 23, 2024
| spawn(async { task() }) | ||
| let (send, recv) = oneshot::channel(); | ||
| wasm_thread::spawn(move || { | ||
| let _ = send.send(task()); |
There was a problem hiding this comment.
What is the let _ = for? Are you suppressing a warning intentionally? (If yes, consider adding a comment. Otherwise, I'd suggest not to use let _ = in the first place.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Atop #2516.
Motivation
Since we rely on parallelism to execute contracts without deadlocking, we need to add parallelism on the Web client to mimic the behaviour of the native client.
Proposal
Add the
wasm_threadlibrary and use it to provide parallelism on the Web.Note: this won't actually work in this repository as configured, because
wasm_threadneeds to be built with nightly Rust, and also have the following unstable target features enabled:Enabling these in this repository, though, will break the examples, since our native Wasm runtime can't handle the atomics instructions that rustc will output. Instead, we have enabled nightly here without the features, and will provide the flags when building from
linera-web.Test Plan
Tested by
linera-web.Release Plan
None.
Links