Receive bundles even if new_outbox_entries. #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
reviewed
Sep 26, 2024
afck
force-pushed
the
receive-bundles-fix
branch
from
2fe6649 to
f5e5601
Compare
ma2bd
approved these changes
Sep 26, 2024
ma2bd
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Receive bundles even if new_outbox_entries. * Use an if statement instead of ||.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a bug in
process_cross_chain_update:new_outbox_entriesis meant to betrueif anyreceive_message_bundlereturned true, so I used||without taking into account that that short-circuits, so thereceive_message_bundlecall isn't actually made ifnew_outbox_entriesis alreadytrue.Proposal
Switch the order of the arguments.
Test Plan
Since this is a simple fix, we could merge that as soon as possible. Coming up with a scenario that exposes this and writing a regression test will take some time (#2544). The failure will probably look similar to the one in #2538, but this fix didn't address that.
Release Plan
devnetbranch, thentestnetbranch, thenLinks