Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fatal warning for tonic_build in CI #2546

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix fatal warning for tonic_build in CI #2546

merged 2 commits into from
Sep 27, 2024

Conversation

ma2bd
Copy link
Contributor

@ma2bd ma2bd commented Sep 26, 2024

Motivation

fix CI after a semver violation by tonic-build (when building with -D warnings)

Proposal

  • Run cargo update
  • Apply the suggestion

I didn't add --locked to the line

cargo install --path linera-service --bin linera --bin linera-server --debug

in .github/workflows/docker.yml because I thought most users may not pass --locked.

Test Plan

CI

Release Plan

Nothing to do

@ma2bd ma2bd merged commit 152ebf5 into linera-io:main Sep 27, 2024
4 checks passed
@ma2bd ma2bd deleted the fix_ci branch September 27, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants