Include chain in client node name.

[afck]

Motivation

The Client is always called "Client node". This makes debugging difficult in tests involving multiple clients.

Proposal

Include the chain ID(s) in the name.

Test Plan

No changed logic, but it should make debugging end-to-end tests easier.

Release Plan

• Nothing to do / These changes follow the usual release cycle.

Links

• (Found while debugging Sync admin chain only when needed #2538.)
• reviewer checklist

[ma2bd]

Why don't we name wallets when we create them? (at random by default and otherwise using a user provided name)

[afck]

Good idea, maybe that's more useful, and also more readable: In the tests they could simply be "Client 1" and "Client 2".

[MathieuDutSik]

It is a minor point, but I find it a little odd that the Client has a name associated with its constructor. Though of course, this is not part of this PR.

[afck]

Yes, like @ma2bd said above: Let's name the wallets instead. I created #2551 for that.

[MathieuDutSik]

Better logging is always welcomed.

[afck]

Merging this, to make it easier to debug issues on main. I created #2551 to name the wallets instead; I'll do that as soon as we're done debugging the failing tests.