Adjust latency metrics buckets #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ndr-ds
force-pushed
the
02-19-have_one_thread_per_chain_on_benchmark
branch
2 times, most recently
from
09f92d3 to
bf4a170
Compare
ndr-ds
force-pushed
the
02-19-adjust_latency_metrics_buckets
branch
from
6401f1f to
dd9fb74
Compare
afck
approved these changes
Feb 20, 2025
ndr-ds
changed the base branch from
02-19-have_one_thread_per_chain_on_benchmark
to
graphite-base/3379
ndr-ds
force-pushed
the
02-19-adjust_latency_metrics_buckets
branch
from
dd9fb74 to
e0591be
Compare
ndr-ds
force-pushed
the
graphite-base/3379
branch
from
bf4a170 to
55f7881
Compare
ma2bd
approved these changes
Feb 20, 2025
ndr-ds
force-pushed
the
02-19-adjust_latency_metrics_buckets
branch
from
e0591be to
8a17d9f
Compare
ndr-ds
force-pushed
the
graphite-base/3379
branch
from
55f7881 to
5bec0eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We don't need to track latencies below 1ms IMHO. Also, for the server latency, I noticed it would very often just shoot to 50ms and stay there the whole time. If you're using few shards (1, like me, for example), shard latency can actually be fairly high.
Proposal
Adjust things
Test Plan
Check the changes on a local network
Release Plan