Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize --with-wallet N to --with-wallet ALPHANUM #3397

Merged
merged 1 commit into from
Feb 23, 2025
Merged

generalize --with-wallet N to --with-wallet ALPHANUM #3397

merged 1 commit into from
Feb 23, 2025

Conversation

ma2bd
Copy link
Contributor

@ma2bd ma2bd commented Feb 23, 2025

Motivation

After #3393, wallet names do not need to be numbers

Proposal

Support alphanumerical wallet names

Test Plan

CI

Twey
Twey approved these changes Feb 23, 2025
View reviewed changes
Copy link
Contributor

@Twey Twey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like this to be a path rather than a substring of an environment variable — but no problems with this as an interim step

@ma2bd
Copy link
Contributor Author

ma2bd commented Feb 23, 2025

I'd still like this to be a path rather than a substring of an environment variable — but no problems with this as an interim step

Yes, that's a possible end result depending how the next refactoring works out

@ma2bd ma2bd merged commit ff42707 into linera-io:main Feb 23, 2025
21 checks passed
@ma2bd ma2bd deleted the misc_cli branch February 23, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Twey Twey Twey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ma2bd @Twey