Make storage configs clonable and serializable #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
changed the title
afck
approved these changes
Feb 24, 2025
| pub struct DynamoDbStoreInternalConfig { | ||
| /// The AWS configuration | ||
| config: aws_sdk_dynamodb::Config, | ||
| /// Whether to use local stack or not. |
There was a problem hiding this comment.
Suggested change
| /// Whether to use local stack or not. | |
| /// Whether to use LocalStack or not. |
MathieuDutSik
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We'd like to simplify config management from databases.
Proposal
The first step is to make storage config objects serializable.
Test Plan
CI