(Port of #3363) Make sure we include end_value in generated Prometheus buckets #3405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-io#3363) Right now we're generating the buckets, but it's not in an inclusive way, and it should be. For latency metrics, for example, you have `end_value` being 500ms, but one of the buckets is 159. Since we're using a multiplication factor of 3, the next bucket would go over 500ms, so we don't include it... Make sure we always include the `end_value` bucket CI + start a network locally and see the correct buckets exported - Nothing to do / These changes follow the usual release cycle.
ndr-ds
force-pushed
the
port_of_3363_to_testnet
branch
from
e59f5fd to
4f7255e
Compare
|
A lot of changes happened in this prometheus code that we didn't backport (mainly #2878). Backporting it would be a huge pain, so I'm just gonna change the buckets manually for now, and when we cut a new testnet we'll have the proper stuff in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now we're generating the buckets, but it's not in an inclusive way, and it should be. For latency metrics, for example, you have
end_valuebeing 500ms, but one of the buckets is 159. Since we're using a multiplication factor of 3, the next bucket would go over 500ms, so we don't include it...Proposal
Make sure we always include the
end_valuebucketTest Plan
CI + start a network locally and see the correct buckets exported
Release Plan