Skip to content

fix: incorrect index for placeholders in useLingui macro #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: incorrect index for placeholders in useLingui macro #2204

merged 1 commit into from
Mar 18, 2025

Conversation

timofei-iatsenko
Copy link
Collaborator

@timofei-iatsenko timofei-iatsenko commented Mar 18, 2025 •
edited
Loading

Description

Correctly process placeholder's indexes in t calls destructed from useLingui macro

fix: #2203

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Mar 18, 2025 0:20am

@timofei-iatsenko timofei-iatsenko marked this pull request as ready for review March 18, 2025 12:21
@github-actions GitHub Actions
Copy link

size-limit report 📦

Path Size
packages/core/dist/index.mjs 2.91 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.35 KB (0%)

andrii-bodnar
andrii-bodnar approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andrii-bodnar andrii-bodnar merged commit 6688f72 into main Mar 18, 2025
10 checks passed
@andrii-bodnar andrii-bodnar deleted the fix/use-lingui-index branch March 18, 2025 12:50
@Docteh Docteh mentioned this pull request May 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract command generates placeholders incorrectly
2 participants
@timofei-iatsenko @andrii-bodnar