Skip to content

chore(examples): fix tanstack-start example on API & SSR requests #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

depsimon
Copy link
Contributor

I noticed the translation in the API and some SSR requests were not working because of the macro not being applied in such cases.

  • I replaced the macro with the i18n._() method
  • I implemented a strategy for detecting the locale in the API (using a header, but can be anything)

Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Mar 27, 2025 2:21pm

@depsimon depsimon changed the title Examples tanstack start fix api chore(examples): fix tanstack-start example on API & SSR requests Mar 27, 2025
Copy link

size-limit report 📦

Path Size
packages/core/dist/index.mjs 2.91 KB (0%)
packages/detect-locale/dist/index.mjs 618 B (0%)
packages/react/dist/index.mjs 1.35 KB (0%)

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (6bb8983) to head (8769d97).
Report is 183 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2210      +/-   ##
==========================================
- Coverage   77.05%   76.79%   -0.27%     
==========================================
  Files          84       88       +4     
  Lines        2157     2486     +329     
  Branches      555      647      +92     
==========================================
+ Hits         1662     1909     +247     
- Misses        382      462      +80     
- Partials      113      115       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@depsimon thank you!

@andrii-bodnar andrii-bodnar merged commit 1e82dd7 into lingui:main Mar 28, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants