Add support for HTTP operations on CoreCLR #78
Conversation
|
Super weird that the tests are hanging in CI. Given that I upgraded some I/O to async, it's possible that things are actually hanging for some reason. I suppose I should test this in a Linux container? (Looks like that's what's happening in CI?) Anyone have any guidance on this? |
There was a problem hiding this comment.
ConfigureAwait(false) is recommended for libraries, so I think those should be added everywhere await or .GetAwaiter().GetResult() is being invoked. There's also an issue of infinite recursion that may explain the never-ending tests.
While there are lots of places in the code where `virtual` is there simply because the Java auto-port treated an absence of `final` as intending overrideability, these two places are INTENDED override points.
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 68.59% 68.72% +0.13%
==========================================
Files 22 23 +1
Lines 4053 4067 +14
Branches 1028 1033 +5
==========================================
+ Hits 2780 2795 +15
+ Misses 1130 1128 -2
- Partials 143 144 +1
Continue to review full report at Codecov.
|
|
Alright. I think we're there. |
|
@asbjornu I've never merged to master yet in this repo. Have you? Also, do you know our usual mechanism for publishing a new minor version to nuget? |
|
Resolved trivial merge conflict. |
|
I'll merge this as soon as the test is green and then it should just (in theory) be to tag the commit with an appropriate version number. I think 1.1.0 is appropriate now, given the amount of stuff that has happened since the last release. |
|
Has this been released already? |
|
@CumpsD, no sorry. Our release pipeline still has some bugs in it and I haven't had time to fix it yet. |
Closes #21
Closes #12