Fix object instantiation in _normalize_inlined()
#392
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a problem that was discovered while converting between TTL and JSON using the schema https://concepts.inm7.de/s/simpleinput/unreleased.yaml The original code used a dictionary as argument to the constructor of a pydantic-class, when it should have used the **-operator to cnvert the dictionary into keyword arguments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
=======================================
Coverage 63.79% 63.79%
=======================================
Files 63 63
Lines 8938 8938
Branches 2584 2584
=======================================
Hits 5702 5702
Misses 2629 2629
Partials 607 607 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -169,7 +169,7 @@ def form_1(entries: dict[Any, Optional[Union[dict, JsonObj]]]) -> None: | |||
| for lek, lev in items(list_entry): | |||
| if lek == key_name and not isinstance(lev, (list, dict, JsonObj)): | |||
| # key_name:value | |||
| order_up(list_entry[lek], slot_type(list_entry)) | |||
| order_up(list_entry[lek], slot_type(**list_entry)) | |||
| break # Not strictly necessary, but | |||
There was a problem hiding this comment.
can you remove this line? not sure why it is in here
| @@ -169,7 +169,7 @@ def form_1(entries: dict[Any, Optional[Union[dict, JsonObj]]]) -> None: | |||
| for lek, lev in items(list_entry): | |||
| if lek == key_name and not isinstance(lev, (list, dict, JsonObj)): | |||
| # key_name:value | |||
| order_up(list_entry[lek], slot_type(list_entry)) | |||
| order_up(list_entry[lek], slot_type(**list_entry)) | |||
There was a problem hiding this comment.
Can you add a test that demonstrates the correctness of the fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a problem that was discovered when using
linkml-convertto convert JSON to TTL using the schema: https://concepts.inm7.de/s/simpleinput/unreleased.yamlThe original code used a dictionary as the argument to the constructor of a Pydantic class, but should have used the
**-operator to convert the dictionary into keyword arguments.