fix: remove finalizers and labels from sealed secrets #2142
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success93 tests passing in 9 suites. Report generated by 🧪jest coverage report action from d72845c |
j-zimnowoda
requested changes
May 12, 2025
| @@ -89,14 +89,6 @@ spec: | |||
| additionalProperties: | |||
| type: string | |||
| type: object | |||
| finalizers: | |||
There was a problem hiding this comment.
This is 3rd party CRD that the operator relies on. We can't just modify it because we can't control any side effects. Moreover these CRD properties are perfectly fine.
|
Now fixed in API: https://github.com/linode/apl-api/pull/722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
Removes finalizer and labels from Sealedsecrets, they were causing a sync error in argoCD.