Skip to content

fix: change order of managing groups and rolemapping #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 16, 2025
Merged

Conversation

ElderMatt
Copy link
Contributor

@ElderMatt ElderMatt commented Jun 5, 2025

This PR changes the order of code, now we first create the groups and afterwards add the group mapping instead of the other way around.

This should help with the following RBAC issue:

  • When a cluster is created and you log in as a platform admin you get a RBAC error because of the group mapping not being applied yet.

Also check APL-CORE PR

@ElderMatt ElderMatt requested a review from CasLubbers as a code owner June 5, 2025 12:55
Copy link

github-actions bot commented Jun 5, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
34.22% (+0.29% 🔼)
388/1134
🔴 Branches
15.44% (+0.06% 🔼)
42/272
🔴 Functions
19.61% (-0.1% 🔻)
40/204
🔴 Lines
34.73% (+0.32% 🔼)
356/1025
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / keycloak.ts
11.96% (+1.21% 🔼)
6.93% (+0.07% 🔼)
6.9% (-0.12% 🔻)
12.84% (+1.32% 🔼)

Test suite run success

25 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 5038981

@ElderMatt ElderMatt marked this pull request as draft June 5, 2025 13:05
@j-zimnowoda j-zimnowoda merged commit 50128e0 into main Jun 16, 2025
5 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-723 branch June 16, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants