[Fix] Controllerserver multivolume fix (#216)

* Fix - we need to return the device path if the volume is attached to the linode

Reason - When the ControllerPublishVolume() is called and times out while waiting for volume to attach to the node, attacher will call the func again. Sometime, the volume might be attached by the time the grpc func is re-executed. This change will check this case and return back the device path so kubelet can use it.

* Remove the test skip for multiVolume

Details - This should be fixed since the main issue was kubelet unable to map the volume on the node

---------

Co-authored-by: Khaja Omer <komer@akamai.com>

Author: komer3

internal/driver/controllerserver.go

@@ -303,7 +303,17 @@ func (cs *ControllerServer) ControllerPublishVolume(ctx context.Context, req *cs
 	}
 	if volume.LinodeID != nil {
 		if *volume.LinodeID == linodeID {
-			return &csi.ControllerPublishVolumeResponse{}, nil
+			klog.V(4).Infof("[ControllerPublishVolume] volume %d is attached on instance %d with path '%s'",
+				volume.ID,
+				*volume.LinodeID,
+				volume.FilesystemPath,
+			)
+			pvInfo := map[string]string{
+				devicePathKey: volume.FilesystemPath,
+			}
+			return &csi.ControllerPublishVolumeResponse{
+				PublishContext: pvInfo,
+			}, nil
 		}
 		return &csi.ControllerPublishVolumeResponse{}, errVolumeAttached(volumeID, linodeID)
 	}

tests/upstream-e2e/run-tests.sh

@@ -14,11 +14,10 @@ tar xzvf ${OUT_TAR} -C ${OUT_DIR}
 
 # Run k8s e2e tests for storage driver
 ./${OUT_DIR}/kubernetes/test/bin/e2e.test                   `# runs kubernetes e2e tests` \
-    -ginkgo.v                                               `# enables verbose output` \
-    -ginkgo.focus='External.Storage'                        `# onl run external storage tests` \
+    --ginkgo.vv                                             `# enables verbose output` \
+    --ginkgo.focus='External.Storage'                       `# only run external storage tests` \
     --ginkgo.skip='\[Disruptive\]'                          `# skip disruptive tests as they need ssh access to nodes` \
     --ginkgo.skip='volume-expand'                           `# skip volume-expand as its done manually for now` \
-    --ginkgo.skip='multiVolume'                             `# skip multi volume as some e2e tests were failing` \
     --ginkgo.skip='snapshottable'                           `# skip as we don't support snapshots` \
     --ginkgo.skip='snapshottable-stress'                    `# skip as we don't support snapshots` \
     --ginkgo.skip='\[Feature:VolumeSnapshotDataSource\]'    `# skip as we don't support snapshots` \