Skip to content

chore: return notFound when disk isn't attached #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

guilhem
Copy link
Contributor

@guilhem guilhem commented Mar 11, 2025

https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/5a645a4b2fe29a52bba3305365c5918d049f1cf0/pkg/csi/service/osutils/linux_os_utils.go#L870

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem guilhem requested review from a team as code owners March 11, 2025 13:53
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.18%. Comparing base (685e341) to head (a4c1f2f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   73.11%   73.18%   +0.07%     
==========================================
  Files          23       23              
  Lines        2648     2648              
==========================================
+ Hits         1936     1938       +2     
+ Misses        585      583       -2     
  Partials      127      127              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guilhem
Copy link
Contributor Author

guilhem commented Mar 12, 2025

⚠️ spec is unclear about what to do here.
Looking at kubernetes code, both return have same action.
This PR could be ignored for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant