[WIP] Remove linode api token requirement from node-server #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the need of the nodeserver to contatc the linode api to get the number of disks attached to the linode by using lsblk.
LINODE_TOKEN to be set.
komer3
reviewed
Apr 21, 2025
Comment on lines
+482
to
+485
| func execRunner(name string, arg ...string) ([]byte, error) { | ||
| return exec.Command(name, arg...).CombinedOutput() | ||
| } | ||
|
|
There was a problem hiding this comment.
Could we use the interfaces defined for exec calls here: https://github.com/linode/linode-blockstorage-csi-driver/blob/d43f82da3e16f6294f1b1cf32eaa3d621c53d044/pkg/mount-manager/safe_mounter.go
This would be helpful during mocking for unit testing
Could you also move the structs and execRunner() to either helper file OR somewhere in the pkg directory?
There was a problem hiding this comment.
What are your thoughts on using this library instead of exec command?
https://github.com/jaypipes/ghw?tab=readme-ov-file#block-storage
jescarri
had a problem deploying
to
prod-external
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines: