[deps] Update Go version, golangci, and kubernetes deps #418

komer3 · 2025-05-02T21:43:04Z

This PR updates several core components of the development environment and dependencies:

Go Version: Upgraded from Go 1.23 to Go 1.24 (1.24.1 toolchain). This allows utilizing the latest language features and improvements. go.mod, devbox.json, and devbox.lock were updated accordingly.
GolangCI-Lint: Upgraded the linting action (golangci-lint-action) to v7 and significantly refactored the .golangci.yml configuration. This adopts the newer config format, enables additional linters, and moves formatting tools (gci, gofmt, goimports) to the formatters section for better structure.
Dependencies: Updated key Go dependencies, notably the Kubernetes client libraries (k8s.io/*) to v0.33.0, ensuring compatibility with newer Kubernetes versions and incorporating upstream fixes.

General:

Have you removed all sensitive information, including but not limited to access keys and passwords?
Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

Does your submission pass tests?
Have you added tests?
Are you addressing a single feature in this PR?
Are your commits atomic, addressing one change per commit?
Are you following the conventions of the language?
Have you saved your large formatting changes for a different PR, so we can focus on your work?
Have you explained your rationale for why this feature is needed?
Have you linked your PR to an open issue

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v6...v7) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps the kubernetes group with 4 updates: [k8s.io/api](https://github.com/kubernetes/api), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery), [k8s.io/client-go](https://github.com/kubernetes/client-go) and [k8s.io/mount-utils](https://github.com/kubernetes/mount-utils). Updates `k8s.io/api` from 0.32.3 to 0.33.0 - [Commits](kubernetes/api@v0.32.3...v0.33.0) Updates `k8s.io/apimachinery` from 0.32.3 to 0.33.0 - [Commits](kubernetes/apimachinery@v0.32.3...v0.33.0) Updates `k8s.io/client-go` from 0.32.3 to 0.33.0 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.3...v0.33.0) Updates `k8s.io/mount-utils` from 0.32.3 to 0.33.0 - [Commits](kubernetes/mount-utils@v0.32.3...v0.33.0) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/apimachinery dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/client-go dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes - dependency-name: k8s.io/mount-utils dependency-version: 0.33.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: kubernetes ... Signed-off-by: dependabot[bot] <support@github.com>

…-43fceea10a' into update-deps

…ci/golangci-lint-action-7' into update-deps

- Bumped Go version from 1.23.1 to 1.24.0 in go.mod and devbox files. - Updated golangci-lint configuration to v2 format in .golangci.yml to streamline settings and enable additional linters. This update enhances compatibility with the latest Go features and improves linting processes.

codecov · 2025-05-02T22:04:41Z

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.69%. Comparing base (1f66948) to head (ce9d5de).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/driver/luks.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   74.01%   70.69%   -3.32%     
==========================================
  Files          24       24              
  Lines        2763     2761       -2     
==========================================
- Hits         2045     1952      -93     
- Misses        586      681      +95     
+ Partials      132      128       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull Request Overview

This PR upgrades core development dependencies, updates linting configuration, and refactors minor code details for consistency. Key changes include:

Upgrading the Go toolchain and Kubernetes dependencies.
Refactoring the GolangCI-Lint configuration with a newer format and additional linters.
Minor code style adjustments in error messages and control flow.

Reviewed Changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/e2e/test/pod-pvc-luks-remount/chainsaw-test.yaml	Updated logging text for better readability.
pkg/linode-volumes/utils_test.go	Removed the Unicode test case, potentially impacting Unicode coverage.
internal/driver/luks.go	Adjusted error message capitalization to align with Go conventions.
internal/driver/controllerserver.go	Simplified abnormal flag assignment logic.
.golangci.yml	Refactored linting configuration with new linters and settings.
.github/workflows/ci.yml	Upgraded golangci-lint-action to version v7.

Files not reviewed (2)

devbox.json: Language not supported
go.mod: Language not supported

Comments suppressed due to low confidence (1)

pkg/linode-volumes/utils_test.go:31

Removing the Unicode characters test case might reduce coverage for non-ASCII inputs. Consider re-adding a test to ensure proper handling of Unicode inputs.

name: "Unicode characters",

Copilot · 2025-05-02T22:21:02Z

.golangci.yml

    - usestdlibvars
    - varnamelen
    - whitespace
+    - zerologlint
+    - unused


A duplicate entry for the 'unused' linter is present in the configuration. Removing one instance could help streamline and avoid redundant linter outputs.

Suggested change

- unused

Wrong find. No duplicates

rahulait

LGTM

dependabot bot and others added 5 commits March 24, 2025 17:08

Merge remote-tracking branch 'origin/dependabot/go_modules/kubernetes…

73a4850

…-43fceea10a' into update-deps

Merge remote-tracking branch 'origin/dependabot/github_actions/golang…

4330195

…ci/golangci-lint-action-7' into update-deps

komer3 requested review from a team as code owners May 2, 2025 21:43

github-actions bot added the dependencies dependency updates including security fixes label May 2, 2025

komer3 added 2 commits May 2, 2025 16:43

Potential fix for the inconsistency with new Luks e2e test

4e2bb60

Merge branch 'main' into update-deps

c644fd4

komer3 had a problem deploying to prod May 2, 2025 21:45 — with GitHub Actions Failure

fix linting errors

ce9d5de

komer3 temporarily deployed to prod May 2, 2025 22:01 — with GitHub Actions Inactive

This was referenced May 2, 2025

🌱 Bump the kubernetes group with 4 updates #416

Closed

🌱 Bump golangci/golangci-lint-action from 6 to 7 #402

Closed

komer3 requested a review from Copilot May 2, 2025 22:20

Copilot AI reviewed May 2, 2025

View reviewed changes

rahulait approved these changes May 6, 2025

View reviewed changes

komer3 merged commit 7854fcb into main May 6, 2025
7 of 9 checks passed

komer3 deleted the update-deps branch May 6, 2025 18:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[deps] Update Go version, golangci, and kubernetes deps #418

[deps] Update Go version, golangci, and kubernetes deps #418

komer3 commented May 2, 2025 •

edited

Loading

codecov bot commented May 2, 2025 •

edited

Loading

Copilot AI left a comment

Copilot AI May 2, 2025

komer3 May 2, 2025

rahulait left a comment

[deps] Update Go version, golangci, and kubernetes deps #418

[deps] Update Go version, golangci, and kubernetes deps #418

Conversation

komer3 commented May 2, 2025 • edited Loading

General:

Pull Request Guidelines:

codecov bot commented May 2, 2025 • edited Loading

Codecov Report

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Copilot AI May 2, 2025

Choose a reason for hiding this comment

komer3 May 2, 2025

Choose a reason for hiding this comment

rahulait left a comment

Choose a reason for hiding this comment

komer3 commented May 2, 2025 •

edited

Loading

codecov bot commented May 2, 2025 •

edited

Loading