Skip to content

Support for dbaas v2 #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 4, 2025
Merged

Support for dbaas v2 #479

merged 11 commits into from
Feb 4, 2025

Conversation

jriddle-linode
Copy link
Collaborator

@jriddle-linode jriddle-linode commented Dec 5, 2024 •
edited
Loading

📝 Description

What does this PR do and why is this change necessary?

Adds new fields for dbaas 2 as well as a mehod for forking.

✔️ How to Test

How do I run the relevant unit/integration tests?

RUN_DB_FORK_TESTS=y make testint TEST_SUITE=database

the tests are still very long so i left the skips in

@jriddle-linode jriddle-linode requested a review from a team as a code owner December 5, 2024 21:53
@jriddle-linode jriddle-linode added the improvement for improvements in existing functionality in the changelog. label Dec 5, 2024
@jriddle-linode jriddle-linode requested review from lgarber-akamai and zliang-akamai and removed request for a team December 5, 2024 21:53
@lgarber-akamai
Copy link
Contributor

@jriddle-linode When you get a chance could you make format?

zliang-akamai
zliang-akamai approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@zliang-akamai zliang-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tests passed

@lgarber-akamai
Copy link
Contributor

lgarber-akamai commented Jan 14, 2025 •
edited
Loading

Great work on this!

I noticed a few test issues when running the full test suite:

  1. Username assertions in the integration tests need to be updated to match the new default (e.g. linroot, linpostgres -> akmadmin).
  2. Assertions need to be updated to the new hostnames (e.g. -mysql-primary.servers.linodedb.net -> .g2a.akamaidb.net).
  3. The MongoDB reference needs to be removed here.
  4. All tests/assertions referencing the backups endpoints can be disabled/removed.
  5. This assertion is failing for some reason.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 3, 2025
View reviewed changes
@ykim-akamai ykim-akamai self-requested a review February 4, 2025 16:56
ykim-akamai
ykim-akamai approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work and thanks for addressing all the failures!

@jriddle-linode jriddle-linode merged commit 761734b into linode:dev Feb 4, 2025
12 checks passed
@jriddle-linode jriddle-linode deleted the new/dbass-aive branch February 4, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zliang-akamai zliang-akamai zliang-akamai approved these changes

@ykim-akamai ykim-akamai ykim-akamai approved these changes

@lgarber-akamai lgarber-akamai Awaiting requested review from lgarber-akamai

Assignees
No one assigned
Labels
improvement for improvements in existing functionality in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jriddle-linode @lgarber-akamai @zliang-akamai @ykim-akamai