Skip to content

ci: several changes related to new qemu test, ansible-lint, python versions, ubuntu versions #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

richm
Copy link
Contributor

@richm richm commented Apr 8, 2025

There is a new QEMU based test which uses the qemu/kvm capability of
github action runners. This is the basis for new bootc/image mode tests
which we will be rolling out in the near future.

ansible-lint requires that the collection path is set so that the requirements
it installs are installed in the correct place.

There has been some general github action deprecation of python versions and
ubuntu versions that we have had to fix.

Remove CONTRIBUTOR from the list of users who can trigger citest.

For more information, see

@richm richm requested a review from spetrosi as a code owner April 8, 2025 18:13
@richm richm self-assigned this Apr 8, 2025
@richm richm force-pushed the changes-20250408 branch from 6e3df86 to e5427ec Compare April 9, 2025 15:17
Copy link

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay green 💚 , so the previous failure was presumably ansible 1.16 dnf5 woes?

@richm richm force-pushed the changes-20250408 branch 3 times, most recently from 2a4406c to 92a88f8 Compare April 11, 2025 00:08
…rsions, ubuntu versions

There is a new QEMU based test which uses the qemu/kvm capability of
github action runners.  This is the basis for new bootc/image mode tests
which we will be rolling out in the near future.

ansible-lint requires that the collection path is set so that the requirements
it installs are installed in the correct place.

There has been some general github action deprecation of python versions and
ubuntu versions that we have had to fix.

Remove `CONTRIBUTOR` from the list of users who can trigger citest.

For more information, see

* linux-system-roles/.github#98
* linux-system-roles/.github#94
* linux-system-roles/.github#93
* linux-system-roles/.github#92
* linux-system-roles/.github#91

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the changes-20250408 branch from 92a88f8 to 9ec7474 Compare April 11, 2025 14:10
@martinpitt
Copy link

martinpitt commented Apr 11, 2025

This test_add_rm failure is a flake and very specific to the tested image. The config looks good, clone1 is the default kernel with correct title and args:

      "ansible_facts": {
          "bootloader_facts": [
              {
                  "args": "no_timer_check console=tty1 console=ttyS0,115200n8 systemd.firstboot=off rootflags=subvol=root test=kernel",
                  "default": true,
                  "id": "f26d5dbc5ba54bfbb3c695a27d7adc47-6.14.0-63.fc42.x86_64_clone1",
                  "index": "0",
                  "initrd": "/boot/initramfs-6.14.0-63.fc42.x86_64.img_clone1",
                  "kernel": "/boot/vmlinuz-6.14.0-63.fc42.x86_64_clone1",
                  "root": "UUID=47f1b394-2df4-43ee-a671-66c16f7a8aeb",
                  "title": "Clone1"
              },
              {
                  "args": "no_timer_check console=tty1 console=ttyS0,115200n8 systemd.firstboot=off rootflags=subvol=root",
                  "default": false,
                  "id": "1031471b08b14ad5b1af48a57b33dfed-6.14.0-63.fc42.x86_64",
                  "index": "1",
                  "initrd": "/boot/initramfs-6.14.0-63.fc42.x86_64.img",
                  "kernel": "/boot/vmlinuz-6.14.0-63.fc42.x86_64",
                  "root": "UUID=47f1b394-2df4-43ee-a671-66c16f7a8aeb",
                  "title": "Fedora Linux (6.14.0-63.fc42.x86_64) 42 (Cloud Edition)"
              }
          ]
      },

and yet this assertion fails:

      "assertion": "(bootloader_facts | selectattr('title', 'defined') | selectattr('title', 'search', 'Clone1') | first).args == __default_args ~ ' test=kernel'"

The test=kernel argument is there, so I suppose __default_args has the wrong value here. Indeed __default_args is taken from the first kernel, which is just wrong -- there is no guarantee that the default kernel isn't the first option (in fact, it seems more logical to be the first option)

I can reproduce this locally with today's image, but not with the one from two days ago (I deleted it now, sorry)

@martinpitt
Copy link

I fixed the test in #137, we can rebase this PR afterwards.

@richm richm merged commit 852ed61 into main Apr 11, 2025
19 of 21 checks passed
@richm richm deleted the changes-20250408 branch April 11, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants