Skip to content

Commit b12af45

Browse files
klangmanklangman
authored
[DesktopCube@yare] Fix animation & dimming issues (#727)
* Mint 21+ and/or Cinnamon 5.4+
1 parent 0ffb81f commit b12af45

File tree

20 files changed

+34
-33
lines changed

20 files changed

+34
-33
lines changed

‎DesktopCube@yare/CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## 1.1.0
4+
5+
* Fixed the "not animating" issue under Mint 21+
6+
* Fixed the under cube background not dimming issue
7+
* Removed some xsession_errors debugging messages
8+
39
## 1.0.2
410

511
* Added an option to remove the panels from the animation effect

‎DesktopCube@yare/README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@ Compiz Cube-like animation for workspace switching
44

55
Using the standard workspace switching hotkeys Ctrl+Alt+Left/Right will show a rotating cube with the workspaces on the cube faces as the workspace switching animation.
66

7-
# Known Issues
8-
9-
On the two machines I have tested with (Cinnamon 6+), the Cube animation does not seem to animate every well unless I set the pullaway setting value to a large number (i.e 0.3+). Even then I see some flashing some times or a complete failure to animate on occasion. I am not sure what's causing it but it happens on a Intel and a AMD GPU setup so I doubt it's a driver issue. I don't see the same issue using very old Mint versions in a Virtual Machine.
7+
It should now be working perfectly under all versions of Mint21+ without having to set CLUTTER_PAINT environment variable!
8+
I tested: Mint 21 / 21.1 / 21.3 / 22 and Fedora Cinnamon-Spin 40

‎DesktopCube@yare/files/DesktopCube@yare/5.4/extension.js

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const Tweener = imports.ui.tweener;
1111
const Settings = imports.ui.settings;
1212
const Util = imports.misc.util; // Needed for spawnCommandLine()
1313

14+
1415
let settings;
1516
let bindings = [
1617
['switch-to-workspace-left', '_showWorkspaceSwitcher'],
@@ -346,6 +347,10 @@ Cube.prototype = {
346347
// Allow Cinnamon to play the switcher sound if it's enabled.
347348
Main.soundManager.play('switch');
348349

350+
// This is a workaround for poor animation, we enable it only during the animation
351+
// sequence so users don't need to set it using export CLUTTER_PAINT...
352+
Meta.add_clutter_debug_flags( 0, 1 << 6, 0 ); // CLUTTER_DEBUG_CONTINUOUS_REDRAW
353+
349354
if (direction === this.last_direction) {
350355
if (this.from != null) {
351356
to_workspace = this.getWorkspaceCloneScaled(new_workspace.index(), direction);
@@ -564,6 +569,7 @@ Cube.prototype = {
564569
this.isAnimating = false;
565570
if (this.destroy_requested) this.onDestroy();
566571
Main.wm.showWorkspaceOSD();
572+
Meta.remove_clutter_debug_flags( 0, 1 << 6, 0 ); // CLUTTER_DEBUG_CONTINUOUS_REDRAW
567573
},
568574

569575
_keyPressEvent: function(actor, event) {
@@ -636,7 +642,8 @@ Cube.prototype = {
636642
this._backgroundGroup.show();
637643
let background = this._backgroundGroup.get_children()[0];
638644
Tweener.addTween(background, {
639-
dim_factor: 0.0,
645+
//dim_factor: 0.0,
646+
opacity: 10,
640647
time: settings.animationTime * 0,
641648
transition: 'easeOutQuad'
642649
});
@@ -707,17 +714,6 @@ CubeSettings.prototype = {
707714

708715
function init(metadata) {
709716
settings = new CubeSettings(metadata.uuid);
710-
711-
log( `animationTime: ${settings.animationTime}` );
712-
log( `pullaway: ${settings.pullaway}` );
713-
log( `scaleEffect: ${settings.newScaleEffect}` );
714-
log( `rotateEffect: ${settings.newRotateEffect}` );
715-
log( `includePanels: ${settings.includePanels}` );
716-
717-
log( `getScaleEffect: ${settings.getScaleEffect()}` );
718-
log( `getUnscaleEffect: ${settings.getUnscaleEffect()}` );
719-
log( `getRotateEffect: ${settings.getRotateEffect()}` );
720-
log( `getUnrotateEffect: ${settings.getUnrotateEffect()}` );
721717
}
722718

723719
function enable() {

‎DesktopCube@yare/files/DesktopCube@yare/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"4.6",
1717
"5.4"
1818
],
19-
"version": "1.0.2",
19+
"version": "1.1.0",
2020
"uuid": "DesktopCube@yare",
2121
"name": "Desktop Cube",
2222
"description": "Compiz Cube-like animation for workspace switching",

‎DesktopCube@yare/files/DesktopCube@yare/po/DesktopCube@yare.pot

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
#, fuzzy
66
msgid ""
77
msgstr ""
8-
"Project-Id-Version: DesktopCube@yare 1.0.2\n"
8+
"Project-Id-Version: DesktopCube@yare 1.1.0\n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: \n"
1313
"Last-Translator: \n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/ca.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ msgstr ""
99
"Project-Id-Version: \n"
1010
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1111
"extensions/issues\n"
12-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
12+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1313
"PO-Revision-Date: 2024-08-25 22:27+0200\n"
1414
"Last-Translator: \n"
1515
"Language-Team: Odyssey <odysseyhyd@gmail.com>\n"

‎DesktopCube@yare/files/DesktopCube@yare/po/da.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2022-08-07 15:06+0200\n"
1313
"Last-Translator: Alan Mortensen <alanmortensen.am@gmail.com>\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/de.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2021-03-02 22:50+0100\n"
1313
"Last-Translator: \n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/es.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2024-08-23 21:44-0400\n"
1313
"Last-Translator: \n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/eu.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2024-05-30 10:18+0200\n"
1313
"Last-Translator: Muxutruk <muxutruk2@users.noreply.github.com>\n"
1414
"Language-Team: Basque <muxutruk2@users.noreply.github.com>\n"

‎DesktopCube@yare/files/DesktopCube@yare/po/fr.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2019-02-13 16:49+0100\n"
1313
"Last-Translator: Claudiux <claude.clerc@gmail.com>\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/hr.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: DesktopCube@yare\n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2017-04-30 16:57+0200\n"
1313
"Last-Translator: gogo <trebelnik2@gmail.com>\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/hu.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2021-09-26 08:16+0200\n"
1313
"Last-Translator: Kálmán „KAMI” Szalai <kami911@gmail.com>\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/it.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2022-06-03 10:52+0200\n"
1313
"Last-Translator: Dragone2 <dragone2@risposteinformatiche.it>\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/nl.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2024-04-16 14:08+0200\n"
1313
"Last-Translator: qadzek\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/pt_BR.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2021-09-26 21:23-0300\n"
1313
"Last-Translator: Marcelo Aof\n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/ro.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2022-08-06 01:55+0200\n"
1313
"Last-Translator: \n"
1414
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/ru.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ msgstr ""
44
"Project-Id-Version: \n"
55
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
66
"extensions/issues\n"
7-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
7+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
88
"PO-Revision-Date: 2023-12-03 14:51-0500\n"
99
"Last-Translator: blogdron\n"
1010
"Language-Team: \n"

‎DesktopCube@yare/files/DesktopCube@yare/po/tr.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgstr ""
88
"Project-Id-Version: \n"
99
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
1010
"extensions/issues\n"
11-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
11+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
1212
"PO-Revision-Date: 2017-09-01 18:36+0300\n"
1313
"Last-Translator: Gökhan Gökkaya <gokhanlnx@gmail.com>\n"
1414
"Language-Team: Linux Mint Türkiye\n"

‎DesktopCube@yare/files/DesktopCube@yare/po/zh_CN.po

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ msgstr ""
44
"Project-Id-Version: \n"
55
"Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
66
"extensions/issues\n"
7-
"POT-Creation-Date: 2024-08-23 18:58-0400\n"
7+
"POT-Creation-Date: 2024-09-06 09:45-0400\n"
88
"PO-Revision-Date: \n"
99
"Last-Translator: \n"
1010
"Language-Team: \n"

0 commit comments

Comments
 (0)