[CinnamonBurnMyWindows@klangman] Fix doom effect randomization (#746)

* The doom effect was not being added to the randomized list of effects when the config option was enabled, this fix will properly add the doom effect to the list of options for random selection.

Author: klangman

CinnamonBurnMyWindows@klangman/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 0.9.3
+
+* Fix Randomized effects so that when the Doom effect is enabled under "Random Effects" it can actually be randomly selected for use
+
 ## 0.9.2
 
 * Added application specific effect settings that override the default effects setting when a specific application window is opened/closed

CinnamonBurnMyWindows@klangman/README.md

@@ -13,17 +13,17 @@ https://github.com/Schneegans/Burn-My-Windows
 
 Cinnamon 6.2 (Mint 22) or better. 
 
-This extension needs the Cinnamon.GLSLEffect class which is only available in Cinnamon 6.2. I had attempted to work around this issue in order to support older versions of Cinnamon but so far I have not been successful.
+This extension needs the Cinnamon.GLSLEffect class which is only available in Cinnamon 6.2.
 
 ## Known issues
 
-In the setting configure window under the "Effect Settings" tab, when changing the "Show setting for effect" drop-down to select a different effect, sometimes the contents under the "Effect Specific Settings" title will not properly update. Because of this, only a subset of the available options are visible. I believe this is a Cinnamon bug. You can force Cinnamon to properly redraw the options by selecting the "General" tab then selecting the "Effect Settings" tab again. After that, the complete set of "Effect Specific Settings" should be visible.
+In the setting configure window under the "Effect Settings" tab, when changing the "Show setting for effect" drop-down to select a different effect, sometimes the contents under the "Effect Specific Settings" title will not properly update. Because of this, only a subset of the available options are visible. I believe this is a Cinnamon bug. You can force Cinnamon to properly redraw the options by selecting the "General" tab then returning to the "Effect Settings" tab again. After that, the complete set of "Effect Specific Settings" should be visible.
 
 When closing the Steam Client "setting" window the 'close window effect' does not show the windows contents, resulting in the closing effect to show where the window had existed but otherwise has no negative effect.
 
-Starting VirtualBox shows a full screen animation of both the Open and Close effect even when the window is not starting maximized. I assume this is caused by some weirdness with how VirtualBox was written.
+Starting VirtualBox shows a full screen animation of both the Open and Close effect even when the window is opening. I assume this is caused by some weirdness with how VirtualBox was written.
 
-The Doom effect seems to finish animating at a noticeably lower position than where the window is actually located. This results in the sudden jump up after the animation is completed.
+The Doom open effect seems to finish animating at a noticeably lower position than where the window is actually located. This results in the sudden jump up after the animation is completed. When used as a close effect it works correctly.
 
 All open window effects seem to animate in a location that is one pixel off the windows real location. This causes a very small (nearly unnoticeable) jump of the window after the animation has finished. The only exception is "Doom", which as stated above has a more pronounced jump.
 

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/6.2/extension.js

@@ -53,16 +53,23 @@ const SignalManager = imports.misc.signalManager;
 
 const Effect = {
   Apparition: 0,
+  BrokenGlass: 1,
+  Doom: 2,
   EnergizeA: 3,
   EnergizeB: 4,
+  Fire: 5,
   Glide: 6,
   Glitch: 7,
   Hexagon: 8,
   Incinerate: 9,
+  Matrix: 10,
+  PaintBrush: 11,
   Pixelate: 12,
   PixelWheel: 13,
   PixelWipe: 14,
   Portal: 15,
+  SnapOfDisintegration: 16,
+  TRexAttack: 17,
   TVEffect: 18,
   TVGlitch: 19,
   Wisps: 20,
@@ -258,10 +265,16 @@ class BurnMyWindows {
       let append = (forOpening)?"-open":"-close";
       if (this._settings.getValue("apparition-random-include" + append))
          effectOptions.push(Effect.Apparition);
+      //if (this._settings.getValue("broken-glass-random-include" + append))
+      //   effectOptions.push(Effect.BrokenGlass);
+      if (this._settings.getValue("doom-random-include" + append))
+         effectOptions.push(Effect.Doom);
       if (this._settings.getValue("energize-a-random-include" + append))
          effectOptions.push(Effect.EnergizeA);
       if (this._settings.getValue("energize-b-random-include" + append))
          effectOptions.push(Effect.EnergizeB);
+      //if (this._settings.getValue("file-random-include" + append))
+      //   effectOptions.push(Effect.Fire);
       if (this._settings.getValue("glide-random-include" + append))
          effectOptions.push(Effect.Glide);
       if (this._settings.getValue("glitch-random-include" + append))
@@ -270,6 +283,10 @@ class BurnMyWindows {
          effectOptions.push(Effect.Hexagon);
       if (this._settings.getValue("incinerate-random-include" + append))
          effectOptions.push(Effect.Incinerate);
+      //if (this._settings.getValue("matrix-random-include" + append))
+      //   effectOptions.push(Effect.Matrix);
+      //if (this._settings.getValue("paint-brush-random-include" + append))
+      //   effectOptions.push(Effect.PaintBrush);
       if (this._settings.getValue("pixelate-random-include" + append))
          effectOptions.push(Effect.Pixelate);
       if (this._settings.getValue("pixel-wheel-random-include" + append))
@@ -278,6 +295,10 @@ class BurnMyWindows {
          effectOptions.push(Effect.PixelWipe);
       if (this._settings.getValue("portal-random-include" + append))
          effectOptions.push(Effect.Portal);
+      //if (this._settings.getValue("snap-of-disintegration-random-include" + append))
+      //   effectOptions.push(Effect.SnapOfDisintegration);
+      //if (this._settings.getValue("trex-attack-random-include" + append))
+      //   effectOptions.push(Effect.TRexAttack);
       if (this._settings.getValue("tv-effect-random-include" + append))
          effectOptions.push(Effect.TVEffect);
       if (this._settings.getValue("tv-glitch-random-include" + append))

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/metadata.json

@@ -1,7 +1,7 @@
 {
   "uuid": "CinnamonBurnMyWindows@klangman",
   "name": "Burn My Windows",
-  "version": "0.9.2",
+  "version": "0.9.3",
   "description": "Window open/close effects based on the Burn-My-Windows Gnome extension by Schneegans",
   "url": "https://github.com/klangman/CinnamonBurnMyWindows",
   "website": "https://github.com/klangman/CinnamonBurnMyWindows",

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/po/CinnamonBurnMyWindows@klangman.pot

@@ -5,10 +5,10 @@
 #, fuzzy
 msgid ""
 msgstr ""
-"Project-Id-Version: CinnamonBurnMyWindows@klangman 0.9.2\n"
+"Project-Id-Version: CinnamonBurnMyWindows@klangman 0.9.3\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
 "extensions/issues\n"
-"POT-Creation-Date: 2024-09-08 23:29-0400\n"
+"POT-Creation-Date: 2024-09-17 22:20-0400\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -17,23 +17,23 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-#. 6.2/extension.js:200 6.2/extension.js:415
+#. 6.2/extension.js:207 6.2/extension.js:436
 msgid "Error"
 msgstr ""
 
-#. 6.2/extension.js:200
+#. 6.2/extension.js:207
 msgid "was NOT enabled"
 msgstr ""
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "The existing extension"
 msgstr ""
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "conflicts with this extension."
 msgstr ""
 
-#. 6.2/extension.js:416
+#. 6.2/extension.js:437
 msgid ""
 "The previously focused window is not backed by an application and therefore "
 "application specific effects can not be applied to that window"

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/po/ca.po

@@ -8,7 +8,7 @@ msgstr ""
 "Project-Id-Version: CinnamonBurnMyWindows@klangman 0.9.1\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
 "extensions/issues\n"
-"POT-Creation-Date: 2024-09-08 23:29-0400\n"
+"POT-Creation-Date: 2024-09-17 22:20-0400\n"
 "PO-Revision-Date: \n"
 "Last-Translator: Odyssey <odysseyhyd@gmail.com>\n"
 "Language-Team: \n"
@@ -18,23 +18,23 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 3.4.2\n"
 
-#. 6.2/extension.js:200 6.2/extension.js:415
+#. 6.2/extension.js:207 6.2/extension.js:436
 msgid "Error"
 msgstr "Error"
 
-#. 6.2/extension.js:200
+#. 6.2/extension.js:207
 msgid "was NOT enabled"
 msgstr "no s'ha activat"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "The existing extension"
 msgstr "L'extensió existent"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "conflicts with this extension."
 msgstr "conflictivitza amb aquesta extensió."
 
-#. 6.2/extension.js:416
+#. 6.2/extension.js:437
 msgid ""
 "The previously focused window is not backed by an application and therefore "
 "application specific effects can not be applied to that window"
@@ -283,8 +283,8 @@ msgid ""
 "Focus a window you want to enable application specific setting for then "
 "return here and press this button."
 msgstr ""
-"Enfoqueu una finestra per a la qual vulgueu activar un ajust específic per "
-"a l'aplicació, torneu aquí i polseu aquest botó."
+"Enfoqueu una finestra per a la qual vulgueu activar un ajust específic per a "
+"l'aplicació, torneu aquí i polseu aquest botó."
 
 #. 6.2->settings-schema.json->random-title->description
 msgid "Effect"

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/po/es.po

@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: CinnamonBurnMyWindows@klangman 0.9.1\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
 "extensions/issues\n"
-"POT-Creation-Date: 2024-09-08 23:29-0400\n"
+"POT-Creation-Date: 2024-09-17 22:20-0400\n"
 "PO-Revision-Date: \n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -17,23 +17,23 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 3.4.4\n"
 
-#. 6.2/extension.js:200 6.2/extension.js:415
+#. 6.2/extension.js:207 6.2/extension.js:436
 msgid "Error"
 msgstr "Error"
 
-#. 6.2/extension.js:200
+#. 6.2/extension.js:207
 msgid "was NOT enabled"
 msgstr "no estaba habilitado"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "The existing extension"
 msgstr "La extensión existente"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "conflicts with this extension."
 msgstr "entra en conflicto con esta extensión."
 
-#. 6.2/extension.js:416
+#. 6.2/extension.js:437
 msgid ""
 "The previously focused window is not backed by an application and therefore "
 "application specific effects can not be applied to that window"

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/po/fr.po

@@ -8,7 +8,7 @@ msgstr ""
 "Project-Id-Version: CinnamonBurnMyWindows@klangman 0.9.2\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
 "extensions/issues\n"
-"POT-Creation-Date: 2024-09-08 23:29-0400\n"
+"POT-Creation-Date: 2024-09-17 22:20-0400\n"
 "PO-Revision-Date: \n"
 "Last-Translator: Claudiux <claude.clerc@gmail.com>\n"
 "Language-Team: \n"
@@ -18,23 +18,23 @@ msgstr ""
 "Content-Transfer-Encoding: 8bit\n"
 "X-Generator: Poedit 3.4.2\n"
 
-#. 6.2/extension.js:200 6.2/extension.js:415
+#. 6.2/extension.js:207 6.2/extension.js:436
 msgid "Error"
 msgstr "Erreur"
 
-#. 6.2/extension.js:200
+#. 6.2/extension.js:207
 msgid "was NOT enabled"
 msgstr "n'a PAS été activée"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "The existing extension"
 msgstr "L'extension existante"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "conflicts with this extension."
 msgstr "est en conflit avec cette extension."
 
-#. 6.2/extension.js:416
+#. 6.2/extension.js:437
 msgid ""
 "The previously focused window is not backed by an application and therefore "
 "application specific effects can not be applied to that window"
@@ -216,8 +216,8 @@ msgid ""
 "Window open/close effects based on the Burn-My-Windows Gnome extension by "
 "Schneegans"
 msgstr ""
-"Effets d'ouverture/fermeture de fenêtres basés sur l'extension Gnome Burn-"
-"My-Windows de Schneegans"
+"Effets d'ouverture/fermeture de fenêtres basés sur l'extension Gnome Burn-My-"
+"Windows de Schneegans"
 
 #. 6.2->settings-schema.json->general-page->title
 msgid "General"

CinnamonBurnMyWindows@klangman/files/CinnamonBurnMyWindows@klangman/po/nl.po

@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: CinnamonBurnMyWindows@klangman 0.9.2\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-"
 "extensions/issues\n"
-"POT-Creation-Date: 2024-09-08 23:29-0400\n"
+"POT-Creation-Date: 2024-09-17 22:20-0400\n"
 "PO-Revision-Date: 2024-09-11 11:19+0200\n"
 "Last-Translator: qadzek\n"
 "Language-Team: \n"
@@ -16,23 +16,23 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-#. 6.2/extension.js:200 6.2/extension.js:415
+#. 6.2/extension.js:207 6.2/extension.js:436
 msgid "Error"
 msgstr "Fout"
 
-#. 6.2/extension.js:200
+#. 6.2/extension.js:207
 msgid "was NOT enabled"
 msgstr "was NIET ingeschakeld"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "The existing extension"
 msgstr "De bestaande extensie"
 
-#. 6.2/extension.js:201
+#. 6.2/extension.js:208
 msgid "conflicts with this extension."
 msgstr "conflicteert met deze extensie."
 
-#. 6.2/extension.js:416
+#. 6.2/extension.js:437
 msgid ""
 "The previously focused window is not backed by an application and therefore "
 "application specific effects can not be applied to that window"