Skip to content

Commit ad1ed06

Browse files
authored
Merge pull request #245 from linuxserver/master-3.21
2 parents 1d957ae + 0d235aa commit ad1ed06

File tree

8 files changed

+42
-25
lines changed

8 files changed

+42
-25
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
FROM ghcr.io/linuxserver/unrar:latest AS unrar
44

5-
FROM ghcr.io/linuxserver/baseimage-alpine:3.20
5+
FROM ghcr.io/linuxserver/baseimage-alpine:3.21
66

77
# set version label
88
ARG BUILD_DATE
@@ -44,7 +44,7 @@ RUN \
4444
pip install -U --no-cache-dir \
4545
pip \
4646
wheel && \
47-
pip install -U --no-cache-dir --find-links https://wheel-index.linuxserver.io/alpine-3.20/ -r requirements.txt && \
47+
pip install -U --no-cache-dir --find-links https://wheel-index.linuxserver.io/alpine-3.21/ -r requirements.txt && \
4848
echo "**** build sab translations ****" && \
4949
python3 tools/make_mo.py && \
5050
echo "**** install par2cmdline-turbo from source ****" && \

Dockerfile.aarch64

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
FROM ghcr.io/linuxserver/unrar:arm64v8-latest AS unrar
44

5-
FROM ghcr.io/linuxserver/baseimage-alpine:arm64v8-3.20
5+
FROM ghcr.io/linuxserver/baseimage-alpine:arm64v8-3.21
66

77
# set version label
88
ARG BUILD_DATE
@@ -44,7 +44,7 @@ RUN \
4444
pip install -U --no-cache-dir \
4545
pip \
4646
wheel && \
47-
pip install -U --no-cache-dir --find-links https://wheel-index.linuxserver.io/alpine-3.20/ -r requirements.txt && \
47+
pip install -U --no-cache-dir --find-links https://wheel-index.linuxserver.io/alpine-3.21/ -r requirements.txt && \
4848
echo "**** build sab translations ****" && \
4949
python3 tools/make_mo.py && \
5050
echo "**** install par2cmdline-turbo from source ****" && \

Jenkinsfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ pipeline {
3535
CI_WEB='true'
3636
CI_PORT='8080'
3737
CI_SSL='false'
38-
CI_DELAY='60'
38+
CI_DELAY='120'
3939
CI_DOCKERENV=''
4040
CI_AUTH=''
4141
CI_WEBPATH=''

README.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,10 @@ The folks over at servarr.com wrote a good [write-up](https://wiki.servarr.com/d
8585

8686
This image can be run with a read-only container filesystem. For details please [read the docs](https://docs.linuxserver.io/misc/read-only/).
8787

88+
## Non-Root Operation
89+
90+
This image can be run with a non-root user. For details please [read the docs](https://docs.linuxserver.io/misc/non-root/).
91+
8892
## Usage
8993

9094
To help you get started creating a container from this image you can either use docker-compose or the docker cli.
@@ -143,6 +147,7 @@ Containers are configured using parameters passed at runtime (such as those abov
143147
| `-v /downloads` | Local path for finished downloads. |
144148
| `-v /incomplete-downloads` | Local path for incomplete-downloads. |
145149
| `--read-only=true` | Run container with a read-only filesystem. Please [read the docs](https://docs.linuxserver.io/misc/read-only/). |
150+
| `--user=1000:1000` | Run container with a non-root user. Please [read the docs](https://docs.linuxserver.io/misc/non-root/). |
146151

147152
## Environment variables from files (Docker secrets)
148153

@@ -306,7 +311,8 @@ Once registered you can define the dockerfile to use with `-f Dockerfile.aarch64
306311

307312
## Versions
308313

309-
* **31.05.24:** - Rebase Alpine 3.20. Remove nzbnotify as apprise is now included with SABnzbd.
314+
* **23.12.24:** - Rebase to Alpine 3.21.
315+
* **31.05.24:** - Rebase to Alpine 3.20. Remove nzbnotify as apprise is now included with SABnzbd.
310316
* **23.12.23:** - Rebase to Alpine 3.19.
311317
* **23.11.23:** - Build translations.
312318
* **13.09.23:** - Use par2cmdline-turbo in place of par2cmdline.

jenkins-vars.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ repo_vars:
2323
- CI_WEB='true'
2424
- CI_PORT='8080'
2525
- CI_SSL='false'
26-
- CI_DELAY='60'
26+
- CI_DELAY='120'
2727
- CI_DOCKERENV=''
2828
- CI_AUTH=''
2929
- CI_WEBPATH=''

readme-vars.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ opt_param_volumes:
3131
- {vol_path: "/downloads", vol_host_path: "/path/to/downloads", desc: "Local path for finished downloads."}
3232
- {vol_path: "/incomplete-downloads", vol_host_path: "/path/to/incomplete/downloads", desc: "Local path for incomplete-downloads."}
3333
readonly_supported: true
34+
nonroot_supported: true
3435
# application setup block
3536
app_setup_block_enabled: true
3637
app_setup_block: |
@@ -90,7 +91,8 @@ init_diagram: |
9091
"sabnzbd:latest" <- Base Images
9192
# changelog
9293
changelogs:
93-
- {date: "31.05.24:", desc: "Rebase Alpine 3.20. Remove nzbnotify as apprise is now included with SABnzbd."}
94+
- {date: "23.12.24:", desc: "Rebase to Alpine 3.21."}
95+
- {date: "31.05.24:", desc: "Rebase to Alpine 3.20. Remove nzbnotify as apprise is now included with SABnzbd."}
9496
- {date: "23.12.23:", desc: "Rebase to Alpine 3.19."}
9597
- {date: "23.11.23:", desc: "Build translations."}
9698
- {date: "13.09.23:", desc: "Use par2cmdline-turbo in place of par2cmdline."}
Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
#!/usr/bin/with-contenv bash
22
# shellcheck shell=bash
33

4-
if grep -qe ' /downloads ' /proc/mounts; then
5-
lsiown abc:abc /downloads
6-
fi
4+
if [[ -z ${LSIO_NON_ROOT_USER} ]]; then
5+
if grep -qe ' /downloads ' /proc/mounts; then
6+
lsiown abc:abc /downloads
7+
fi
78

8-
if grep -qe ' /incomplete-downloads ' /proc/mounts; then
9-
lsiown abc:abc /incomplete-downloads
10-
fi
9+
if grep -qe ' /incomplete-downloads ' /proc/mounts; then
10+
lsiown abc:abc /incomplete-downloads
11+
fi
1112

12-
find /config -path /config/Downloads -prune -o -exec lsiown abc:abc {} +
13+
find /config -path /config/Downloads -prune -o -exec lsiown abc:abc {} +
14+
fi

root/etc/s6-overlay/s6-rc.d/svc-sabnzbd/run

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,21 @@
33

44
FAMILY=::
55

6-
if [[ "$HAS_IPV6" = "false" ]]; then
7-
FAMILY=0.0.0.0
8-
sed '/ip6-/d' /etc/hosts > /etc/hosts.new
9-
cat /etc/hosts.new > /etc/hosts
10-
rm /etc/hosts.new
11-
fi
6+
if [[ -z ${LSIO_NON_ROOT_USER} ]]; then
7+
if [[ "$HAS_IPV6" = "false" ]]; then
8+
FAMILY=0.0.0.0
9+
sed '/ip6-/d' /etc/hosts > /etc/hosts.new
10+
cat /etc/hosts.new > /etc/hosts
11+
rm /etc/hosts.new
12+
fi
1213

13-
exec \
14-
s6-notifyoncheck -d -n 300 -w 1000 \
15-
s6-setuidgid abc python3 /app/sabnzbd/SABnzbd.py \
16-
--config-file /config --server "$FAMILY"
14+
exec \
15+
s6-notifyoncheck -d -n 300 -w 1000 \
16+
s6-setuidgid abc python3 /app/sabnzbd/SABnzbd.py \
17+
--config-file /config --server "$FAMILY"
18+
else
19+
exec \
20+
s6-notifyoncheck -d -n 300 -w 1000 \
21+
python3 /app/sabnzbd/SABnzbd.py \
22+
--config-file /config --server "$FAMILY"
23+
fi

0 commit comments

Comments
 (0)