Skip to content

feat: refactor init and replace sed with jq #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat: refactor init and replace sed with jq #294

merged 1 commit into from
Nov 22, 2024

Conversation

nemchik
Copy link
Member

@nemchik nemchik commented Nov 14, 2024 •
edited
Loading

@nemchik
feat: refactor init and replace sed with jq
4ca6808 
Signed-off-by: Eric Nemchik <eric@nemchik.com>
@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-b6d4b051-dev-4ca680899ef161b1cf5503df832776a57e2db15e-pr-294/index.html
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-b6d4b051-dev-4ca680899ef161b1cf5503df832776a57e2db15e-pr-294/shellcheck-result.xml

Tag Passed
amd64-4.0.6-r0-pkg-b6d4b051-dev-4ca680899ef161b1cf5503df832776a57e2db15e-pr-294 ✅
arm64v8-4.0.6-r0-pkg-b6d4b051-dev-4ca680899ef161b1cf5503df832776a57e2db15e-pr-294 ✅

@nemchik nemchik mentioned this pull request Nov 14, 2024
Closed
1 task
uhop
uhop approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@uhop uhop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos for the nice cleanup!

@nemchik nemchik requested a review from a team November 14, 2024 01:52
@nemchik
Copy link
Member Author

nemchik commented Nov 14, 2024

Confirmed working #292 (comment)

@drizuid
Copy link
Member

drizuid commented Nov 14, 2024

pending confirmation here too - https://discord.com/channels/354974912613449730/1306316845674135582

@nemchik
Copy link
Member Author

nemchik commented Nov 16, 2024

pending confirmation here too - https://discord.com/channels/354974912613449730/1306316845674135582

Confirmation received.

@LinuxServer-CI
Copy link
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-8cf41475-dev-cc5d3545a9c473bcd61c5bf5d36dd3da0fab3a12-pr-294/index.html
https://ci-tests.linuxserver.io/lspipepr/transmission/4.0.6-r0-pkg-8cf41475-dev-cc5d3545a9c473bcd61c5bf5d36dd3da0fab3a12-pr-294/shellcheck-result.xml

Tag Passed
amd64-4.0.6-r0-pkg-8cf41475-dev-cc5d3545a9c473bcd61c5bf5d36dd3da0fab3a12-pr-294 ✅
arm64v8-4.0.6-r0-pkg-8cf41475-dev-cc5d3545a9c473bcd61c5bf5d36dd3da0fab3a12-pr-294 ✅

@nemchik nemchik merged commit 42e8761 into master Nov 22, 2024
12 checks passed
@nemchik nemchik deleted the refactor-init branch November 22, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhop uhop uhop approved these changes

@thespad thespad thespad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issue & PR Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nemchik @LinuxServer-CI @drizuid @uhop @thespad