Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vesting precompile #3263

Merged
merged 17 commits into from
Feb 21, 2025
Merged

Add vesting precompile #3263

merged 17 commits into from
Feb 21, 2025

Conversation

wangminqi
Copy link
Member

Add vesting precompile

Copy link

linear bot commented Feb 20, 2025

@wangminqi wangminqi requested review from Kailai-Wang and a team February 20, 2025 06:35
@@ -0,0 +1,9 @@
// SPDX-License-Identifier: GPL-3.0-only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test case in parachain ts-tests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I will add one.

@wangminqi wangminqi requested a review from 0xverin February 20, 2025 07:57
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still seems to fail

@@ -118,6 +119,12 @@ pub type PrecompilesSetAt<R> = (
PrecompileAt<AddressU64<1026>, ECRecoverPublicKey, (CallableByContract, CallableByPrecompile)>,
PrecompileAt<AddressU64<1027>, Ed25519Verify, (CallableByContract, CallableByPrecompile)>,
// Litentry precompiles (starts from 0x5000):
// ParachainStaking: pallet_parachain_staking = 15 + 20480
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why not 11 + 20480 to make it consistent? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

@Kailai-Wang Kailai-Wang enabled auto-merge (squash) February 21, 2025 13:14
@Kailai-Wang Kailai-Wang merged commit 1ee2f88 into dev Feb 21, 2025
20 checks passed
@Kailai-Wang Kailai-Wang deleted the p-1333-vesting-precompile branch February 21, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants