Skip to content

Enhancement: recurring ping in sse response #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixartemev opened this issue Mar 31, 2025 · 4 comments
Open

Enhancement: recurring ping in sse response #4082

mixartemev opened this issue Mar 31, 2025 · 4 comments
Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on

Comments

@mixartemev
Copy link

mixartemev commented Mar 31, 2025

Summary

problem: response failed due to timeout if no events come for a long time;
proposal: add ping message every x seconds in sse response.

Basic Example

like in sse-starlette

Drawbacks and Impact

No response

Unresolved questions

No response

@mixartemev mixartemev added the Enhancement This is a new feature or request label Mar 31, 2025
@mixartemev mixartemev changed the title Enhancement: recurring ping in sse responce Enhancement: recurring ping in sse response Mar 31, 2025
@euri10
Copy link
Contributor

euri10 commented Apr 3, 2025

hi @mixartemev , I'm not aware of a timeout on sse, would you have an example please ?

@mixartemev
Copy link
Author

@euri10 Probably it's a feature of telegram only (telegram mini applications).
In browser no sse-timeouts indeed, but in TMA sse response with no ping, fails exactly after 1 minute.

Image

on the screenshot in response onsse-order returns ping every 55 seconds, and sse-msgs with no ping fails after 60 seconds

@euri10
Copy link
Contributor

euri10 commented Apr 3, 2025

seems like a good addition then

@provinzkraut
Copy link
Member

Mh. If we add this, it should probably be optional.

@provinzkraut provinzkraut added the Good First Issue This is good for newcomers to take on label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on
Projects
None yet
Development

No branches or pull requests

3 participants