Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor warning fixes for RISC-V Clang builds #430

Merged
merged 6 commits into from
Jan 8, 2025
Merged

Various minor warning fixes for RISC-V Clang builds #430

merged 6 commits into from
Jan 8, 2025

Conversation

arichardson
Copy link
Contributor

I noticed a few warnings while building RISC-V with LLVM 17, this PR should fix them.

@arichardson
riscv: Add missing parens around macro argument
69e9bf8 
This triggered a out of range count overflow warning when
building for RV32 (calling the macro with `ticks >> 32`)
since the truncation happened before the shift.
@arichardson
libcpp: fix deprecated builtin warning with clang
6ba794f
@arichardson
riscv: ensure arguments to __ASM_STR() are expanded first
418100f 
Right now this does not cause any issues, but I had a local change where
missing expansion resulted in compilation errors when reading CSRs.
@arichardson
riscv: add missing stdint.h include
3db8a96 
While this is currently pulled in transitively, uint32_t is defined there
and we should explicitly include the appropriate header.
@arichardson
pci: remove write-only variable
dcd35c7 
This is not used anywhere so just drop it.
@arichardson
dlmalloc: fix -Wstrict-prototypes warning
dca9f65
@arichardson
Copy link
Contributor Author

The CI failures seem unrelated just lots of network issues

E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/g/gst-plugins-base1.0/libgstreamer-plugins-base1.0-0_1.24.2-1ubuntu0.1_amd64.deb  404  Not Found [IP: 40.81.13.82 80]
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/g/gst-plugins-base1.0/gstreamer1.0-plugins-base_1.24.2-1ubuntu0.1_amd64.deb  404  Not Found [IP: 40.81.13.82 80]
E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/g/gst-plugins-base1.0/gstreamer1.0-x_1.24.2-1ubuntu0.1_amd64.deb  404  Not Found [IP: 40.81.13.82 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@travisg
Copy link
Member

travisg commented Jan 7, 2025

Yeah I might have to file a bug with github about that. I'm guessing they preload their VMs with local file versions of most of the usual packages and those 3 are not prepopulated so it tries to fetch from the network and for some reason that's not configured or actively blocked.

@travisg travisg merged commit 0fd355e into littlekernel:master Jan 8, 2025
204 of 213 checks passed
@travisg
Copy link
Member

travisg commented Jan 8, 2025

LGTM! thanks

@arichardson arichardson deleted the minor-warning-fixes branch January 9, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arichardson @travisg