-
Notifications
You must be signed in to change notification settings - Fork 1
Avatar support + remove krisp #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -27,6 +27,13 @@ struct ChatView: View { | |||
} | |||
.listStyle(.plain) | |||
.scrollIndicators(.hidden) | |||
.mask( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
@EnvironmentObject private var room: Room | ||
@EnvironmentObject private var participant: Participant | ||
|
||
private var worker: RemoteParticipant? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move it to Room extension for a clearer picture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would need to move to a new Participant extension if anything, but our focus should be on just solving this in the SDK automatically.
SwiftUIVideoView(cameraTrack) | ||
.clipShape(RoundedRectangle(cornerRadius: 8)) | ||
} else { | ||
AgentBarAudioVisualizer(audioTrack: micTrack, agentState: participant.agentState, barColor: .primary, barCount: 5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some opportunity to merge it with ParticipantView
with very similar logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah participantview needs to be updated to handle agent state. ideally once we make the necessary framework updates this whole sample app becomes quite simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pblazej weird I don't know how that even happened. good catch. i had a scheme and it was marked shared but i had to delete and recreate it for the xcshareddata entry to appear |
This started as a few tweaks to #12 but I needed to make some deeper changes to reliably load the avatar and also incorporated design direction from discussion with @mattherzog (although it's not final and isn't based on a specific mockup)
I also removed krisp while I was in here, in favor of the agent-side krisp