Skip to content

Build/CI: Modernize build.yml #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025
Merged

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented May 31, 2025

  • Test on more Java versions
  • Remove travis.yml; unused

* Test on more Java versions
* Remove travis.yml; unused
@dsmiley dsmiley requested a review from Copilot May 31, 2025 02:10
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR replaces the deprecated Travis CI configuration with a modern GitHub Actions workflow, expands testing across multiple Java versions, and adds unit-test result publishing.

  • Removed .travis.yml as it is no longer used.
  • Updated .github/workflows/build.yml to run on pushes and PRs to main/master, bumped Action versions, and added a Java matrix including JDK 8, 11, 17, and 21.
  • Added a step to publish JUnit test results after the Maven build.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.travis.yml Deleted unused Travis CI config
.github/workflows/build.yml Migrated CI to GitHub Actions, added Java version matrix, and test-report publishing
Comments suppressed due to low confidence (3)

.github/workflows/build.yml:34

  • Expand the test report glob to include integration test outputs (e.g., target/failsafe-reports/*.xml) to ensure complete coverage in the published results.
files: target/surefire-reports/*.xml

.github/workflows/build.yml:8

  • [nitpick] If your repository has standardized on 'main' as the default branch, consider removing 'master' to simplify workflow triggers and avoid unused pipeline runs.
branches: [ main, master ]

.github/workflows/build.yml:15

  • [nitpick] Consider adding 'fail-fast: false' under the strategy to ensure all JDK matrix jobs run even if one fails, providing a full view of compatibility issues.
strategy:

@dsmiley dsmiley merged commit f00180e into locationtech:master May 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant