Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #96

Merged
merged 3 commits into from
Aug 23, 2024
Merged

Dev #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54ecf84
[#78] 스웨거 cors 에러 접근 허용 주석처리 (#80)
qzzloz Aug 22, 2024
fb23ccb
fix : 리뷰 수정 메서드 Put으로 변경
KkomSang Aug 23, 2024
854a519
Merge pull request #95 from locavell/fix/#94
KkomSang Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/example/locavel/config/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ public CorsConfiguration getCorsConfiguration(HttpServletRequest request) {
.requestMatchers("/api/users/{user_id}/grade").permitAll()
//TODO : 헬스체크용 api 허용
.requestMatchers("/health").permitAll()
// .requestMatchers("/swagger-ui/**", "/v3/api-docs/**").permitAll()
.anyRequest().authenticated()) // 위의 경로 이외에는 모두 인증된 사용자만 접근 가능
.logout(logout -> logout
.logoutUrl("/api/auth/logout")
Expand Down
4 changes: 2 additions & 2 deletions src/main/java/com/example/locavel/service/ReviewService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ public ReviewResponseDTO.ReviewUpdateResultDTO updateReview(Long reviewId, Revie
Reviews review = reviewRepository.findById(reviewId)
.orElseThrow(()->new ReviewsHandler(ErrorStatus.REVIEW_NOT_FOUND));
Places place = review.getPlace();
if(request.getRating() != null) {review.setRating(request.getRating());}
if(request.getComment() != null) {review.setComment(request.getComment());}
review.setRating(request.getRating());
review.setComment(request.getComment());
if(reviewImgUrls != null) {uploadReviewImg(reviewImgUrls, review, true);}
Reviews updatedReview = reviewRepository.save(review);
placeService.setReview(place);
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/example/locavel/web/controller/ReviewRestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public ApiResponse<ReviewResponseDTO.ReviewResultDTO> createReview(
}

@Operation(summary = "리뷰 수정", description = "리뷰를 수정합니다.")
@PatchMapping(value = "/{reviewId}", consumes = "multipart/form-data")
@PutMapping(value = "/{reviewId}", consumes = "multipart/form-data")
public ApiResponse<ReviewResponseDTO.ReviewUpdateResultDTO> updateReview(
@Valid @RequestPart ReviewRequestDTO.ReviewDTO request,
@PathVariable(name="reviewId") Long reviewId,
Expand Down