Skip to content

Commit 03f07d1

Browse files
committed
Fix no-opt tests APP_API_KEY
It has to be set up for login tests.
1 parent 2c33ecc commit 03f07d1

File tree

2 files changed

+6
-14
lines changed

2 files changed

+6
-14
lines changed

.github/workflows/optional-dependency.yml

+5-3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ name: optional-dependency
22

33
on: pull_request
44

5+
env:
6+
APP_API_KEY: ${{ secrets.APP_API_KEY }}
7+
ENABLE_HOPSWORKS_USAGE: "false"
8+
59
jobs:
610
unit_tests_no_great_expectations:
711
name: Unit Testing (No Great Expectations)
@@ -24,6 +28,4 @@ jobs:
2428
- run: pip install -e python[python,dev-no-opt]
2529

2630
- name: Run Pytest suite
27-
env:
28-
ENABLE_HOPSWORKS_USAGE: "false"
29-
run: pytest python/tests
31+
run: pytest python/tests

.github/workflows/python-lint.yml

+1-11
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ on: pull_request
44

55
env:
66
APP_API_KEY: ${{ secrets.APP_API_KEY }}
7+
ENABLE_HOPSWORKS_USAGE: "false"
78

89
jobs:
910
lint_stylecheck:
@@ -76,8 +77,6 @@ jobs:
7677
run: python --version
7778

7879
- name: Run Pytest suite
79-
env:
80-
ENABLE_HOPSWORKS_USAGE: "false"
8180
run: pytest python/tests
8281

8382
unit_tests_ubuntu_pandas:
@@ -105,8 +104,6 @@ jobs:
105104
run: python --version
106105

107106
- name: Run Pytest suite
108-
env:
109-
ENABLE_HOPSWORKS_USAGE: "false"
110107
run: pytest python/tests
111108

112109
unit_tests_ubuntu_local:
@@ -134,8 +131,6 @@ jobs:
134131
run: python --version
135132

136133
- name: Run Pytest suite
137-
env:
138-
ENABLE_HOPSWORKS_USAGE: "false"
139134
run: pytest python/tests
140135

141136
unit_tests_ubuntu_typechecked:
@@ -158,7 +153,6 @@ jobs:
158153

159154
- name: Run Pytest suite
160155
env:
161-
ENABLE_HOPSWORKS_USAGE: "false"
162156
HOPSWORKS_RUN_WITH_TYPECHECK: "true"
163157
run: pytest python/tests
164158
continue-on-error: true
@@ -188,8 +182,6 @@ jobs:
188182
run: python --version
189183

190184
- name: Run Pytest suite
191-
env:
192-
ENABLE_HOPSWORKS_USAGE: "false"
193185
run: pytest python/tests
194186

195187
unit_tests_windows_local:
@@ -220,6 +212,4 @@ jobs:
220212
run: pip freeze
221213

222214
- name: Run Pytest suite
223-
env:
224-
ENABLE_HOPSWORKS_USAGE: "false"
225215
run: pytest python/tests

0 commit comments

Comments
 (0)