remove save_code

Author: bubriks

python/hsfs/feature_group.py

@@ -2645,7 +2645,6 @@ def insert(
         storage: Optional[str] = None,
         write_options: Optional[Dict[str, Any]] = None,
         validation_options: Optional[Dict[str, Any]] = None,
-        save_code: Optional[bool] = True,
         wait: bool = False,
     ) -> Tuple[Optional[Job], Optional[ValidationReport]]:
         """Persist the metadata and materialize the feature group to the feature store
@@ -2751,10 +2750,6 @@ def insert(
                 * key `ge_validate_kwargs` a dictionary containing kwargs for the validate method of Great Expectations.
                 * key `fetch_expectation_suite` a boolean value, by default `True`, to control whether the expectation
                    suite of the feature group should be fetched before every insert.
-            save_code: When running HSFS on Hopsworks or Databricks, HSFS can save the code/notebook used to create
-                the feature group or used to insert data to it. When calling the `insert` method repeatedly
-                with small batches of data, this can slow down the writes. Use this option to turn off saving
-                code. Defaults to `True`.
             wait: Wait for job to finish before returning, defaults to `False`.
                 Shortcut for read_options `{"wait_for_job": False}`.
 
@@ -3721,7 +3716,6 @@ def insert(
         ],
         write_options: Optional[Dict[str, Any]] = None,
         validation_options: Optional[Dict[str, Any]] = None,
-        save_code: Optional[bool] = True,
         wait: bool = False,
     ) -> Tuple[
         None, Optional[great_expectations.core.ExpectationSuiteValidationResult]
@@ -3774,10 +3768,6 @@ def insert(
                 * key `ge_validate_kwargs` a dictionary containing kwargs for the validate method of Great Expectations.
                 * key `fetch_expectation_suite` a boolean value, by default `True`, to control whether the expectation
                    suite of the feature group should be fetched before every insert.
-            save_code: When running HSFS on Hopsworks or Databricks, HSFS can save the code/notebook used to create
-                the feature group or used to insert data to it. When calling the `insert` method repeatedly
-                with small batches of data, this can slow down the writes. Use this option to turn off saving
-                code. Defaults to `True`.
 
         # Returns
             Tuple(None, `ge.core.ExpectationSuiteValidationResult`) The validation report if validation is enabled.

python/hsfs/feature_group_writer.py

@@ -55,8 +55,7 @@ def insert(
             operation=operation,
             storage=storage,
             write_options={"start_offline_materialization": False, **write_options},
-            validation_options={"fetch_expectation_suite": False, **validation_options},
-            save_code=False,
+            validation_options={"fetch_expectation_suite": False, **validation_options}
         )
 
     def __exit__(self, exc_type, exc_value, exc_tb):

python/tests/test_feature_group_writer.py

@@ -42,8 +42,7 @@ def test_fg_writer_context_manager(self, mocker, dataframe_fixture_basic):
             operation="upsert",
             storage=None,
             write_options={"start_offline_materialization": False},
-            validation_options={"fetch_expectation_suite": False},
-            save_code=False,
+            validation_options={"fetch_expectation_suite": False}
         )
         assert fg._multi_part_insert is False