Skip to content

Commit 32e49e7

Browse files
committed
some test fixes
1 parent 969dde8 commit 32e49e7

File tree

3 files changed

+80
-154
lines changed

3 files changed

+80
-154
lines changed

python/tests/core/test_kafka_engine.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ def test_kafka_get_offsets_high(self, mocker):
340340
)
341341

342342
# Assert
343-
assert result == f" -initialCheckPointString {topic_name},0:11"
343+
assert result == f"{topic_name},0:11"
344344

345345
def test_kafka_get_offsets_low(self, mocker):
346346
# Arrange
@@ -372,7 +372,7 @@ def test_kafka_get_offsets_low(self, mocker):
372372
)
373373

374374
# Assert
375-
assert result == f" -initialCheckPointString {topic_name},0:0"
375+
assert result == f"{topic_name},0:0"
376376

377377
def test_kafka_get_offsets_no_topic(self, mocker):
378378
# Arrange

python/tests/engine/test_python.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -2962,7 +2962,7 @@ def test_materialization_kafka_first_job_execution(self, mocker):
29622962
mocker.patch("hsfs.util.get_job_url")
29632963
mocker.patch(
29642964
"hsfs.core.kafka_engine.kafka_get_offsets",
2965-
return_value=" tests_offsets",
2965+
return_value="tests_offsets",
29662966
)
29672967
mocker.patch(
29682968
"hsfs.core.job_api.JobApi.last_execution",
@@ -3004,7 +3004,7 @@ def test_materialization_kafka_first_job_execution(self, mocker):
30043004
# Assert
30053005
assert mock_python_engine_kafka_produce.call_count == 4
30063006
job_mock.run.assert_called_once_with(
3007-
args="defaults tests_offsets",
3007+
args="defaults -initialCheckPointString tests_offsets",
30083008
await_termination=False,
30093009
)
30103010

@@ -3020,7 +3020,7 @@ def test_materialization_kafka_skip_offsets(self, mocker):
30203020
mocker.patch("hsfs.util.get_job_url")
30213021
mocker.patch(
30223022
"hsfs.core.kafka_engine.kafka_get_offsets",
3023-
return_value=" tests_offsets",
3023+
return_value="tests_offsets",
30243024
)
30253025

30263026
mocker.patch("hopsworks_common.client.get_instance")
@@ -3061,7 +3061,7 @@ def test_materialization_kafka_skip_offsets(self, mocker):
30613061
# Assert
30623062
assert mock_python_engine_kafka_produce.call_count == 4
30633063
job_mock.run.assert_called_once_with(
3064-
args="defaults tests_offsets",
3064+
args="defaults -initialCheckPointString tests_offsets",
30653065
await_termination=False,
30663066
)
30673067

@@ -3077,7 +3077,7 @@ def test_materialization_kafka_topic_doesnt_exist(self, mocker):
30773077
mocker.patch("hsfs.util.get_job_url")
30783078
mocker.patch(
30793079
"hsfs.core.kafka_engine.kafka_get_offsets",
3080-
side_effect=["", " tests_offsets"],
3080+
side_effect=["", "tests_offsets"],
30813081
)
30823082

30833083
mocker.patch("hopsworks_common.client.get_instance")
@@ -3115,7 +3115,7 @@ def test_materialization_kafka_topic_doesnt_exist(self, mocker):
31153115
# Assert
31163116
assert mock_python_engine_kafka_produce.call_count == 4
31173117
job_mock.run.assert_called_once_with(
3118-
args="defaults tests_offsets",
3118+
args="defaults -initialCheckPointString tests_offsets",
31193119
await_termination=False,
31203120
)
31213121

0 commit comments

Comments
 (0)