[FSTORE-1483] Remove the code back end and client code (#253)

* init (not tested)

* add temp message for sanity

* undo sanity check

* remove save_code

Author: bubriks

java/hsfs/src/main/java/com/logicalclocks/hsfs/engine/CodeEngine.java

@@ -32,7 +32,6 @@
 
 import com.logicalclocks.hsfs.StorageConnector;
 import com.logicalclocks.hsfs.constructor.QueryBase;
-import com.logicalclocks.hsfs.engine.CodeEngine;
 import com.logicalclocks.hsfs.FeatureGroupBase;
 import com.logicalclocks.hsfs.metadata.OnDemandOptions;
 import com.logicalclocks.hsfs.metadata.Statistics;
@@ -81,7 +80,6 @@ public class ExternalFeatureGroup extends FeatureGroupBase<Dataset<Row>> {
   private final FeatureGroupEngine featureGroupEngine = new FeatureGroupEngine();
 
   private final StatisticsEngine statisticsEngine = new StatisticsEngine(EntityEndpointType.FEATURE_GROUP);
-  private final CodeEngine codeEngine = new CodeEngine(EntityEndpointType.FEATURE_GROUP);
 
   @Builder
   public ExternalFeatureGroup(FeatureStore featureStore, @NonNull String name, Integer version, String query,
@@ -127,7 +125,6 @@ public ExternalFeatureGroup(FeatureStore featureStore, int id) {
 
   public void save() throws FeatureStoreException, IOException {
     featureGroupEngine.saveExternalFeatureGroup(this);
-    codeEngine.saveCode(this);
     if (statisticsConfig.getEnabled()) {
       statisticsEngine.computeStatistics(this, read(), null);
     }
@@ -262,7 +259,6 @@ public void insert(Dataset<Row> featureData)
 
     featureGroupEngine.insert(this, featureData, null);
 
-    codeEngine.saveCode(this);
     computeStatistics();
   }
 
@@ -299,7 +295,6 @@ public void insert(Dataset<Row> featureData, Map<String, String> writeOptions)
 
     featureGroupEngine.insert(this, featureData, writeOptions);
 
-    codeEngine.saveCode(this);
     computeStatistics();
   }
 

java/hsfs/src/main/java/com/logicalclocks/hsfs/metadata/Code.java

@@ -31,7 +31,6 @@
 import com.logicalclocks.hsfs.StatisticsConfig;
 import com.logicalclocks.hsfs.Storage;
 import com.logicalclocks.hsfs.TimeTravelFormat;
-import com.logicalclocks.hsfs.engine.CodeEngine;
 import com.logicalclocks.hsfs.FeatureGroupBase;
 import com.logicalclocks.hsfs.metadata.Statistics;
 import lombok.AllArgsConstructor;
@@ -58,7 +57,6 @@ public class FeatureGroup extends FeatureGroupBase<Dataset<Row>> {
 
   private final FeatureGroupEngine featureGroupEngine = new FeatureGroupEngine();
   protected StatisticsEngine statisticsEngine = new StatisticsEngine(EntityEndpointType.FEATURE_GROUP);
-  private final CodeEngine codeEngine = new CodeEngine(EntityEndpointType.FEATURE_GROUP);
 
   @Builder
   public FeatureGroup(FeatureStore featureStore, @NonNull String name, Integer version,
@@ -419,7 +417,6 @@ public void save(Dataset<Row> featureData, Map<String, String> writeOptions)
       throws FeatureStoreException, IOException, ParseException {
     featureGroupEngine.save(this, featureData, partitionKeys, hudiPrecombineKey,
         writeOptions);
-    codeEngine.saveCode(this);
     if (statisticsConfig.getEnabled()) {
       statisticsEngine.computeStatistics(this, featureData, null);
     }
@@ -744,7 +741,6 @@ public void insert(Dataset<Row> featureData, Storage storage, boolean overwrite,
     featureGroupEngine.insert(this, featureData, storage, operation,
         overwrite ? SaveMode.Overwrite : SaveMode.Append, partitionKeys, hudiPrecombineKey, writeOptions);
 
-    codeEngine.saveCode(this);
     computeStatistics();
   }
 

java/hsfs/src/main/java/com/logicalclocks/hsfs/metadata/CodeApi.java

@@ -29,7 +29,6 @@
 import com.logicalclocks.hsfs.JobConfiguration;
 import com.logicalclocks.hsfs.StatisticsConfig;
 import com.logicalclocks.hsfs.Storage;
-import com.logicalclocks.hsfs.engine.CodeEngine;
 import com.logicalclocks.hsfs.FeatureGroupBase;
 import com.logicalclocks.hsfs.metadata.Statistics;
 
@@ -56,7 +55,6 @@ public class StreamFeatureGroup extends FeatureGroupBase<Dataset<Row>> {
 
   protected FeatureGroupEngine featureGroupEngine = new FeatureGroupEngine();
   private final StatisticsEngine statisticsEngine = new StatisticsEngine(EntityEndpointType.FEATURE_GROUP);
-  private final CodeEngine codeEngine = new CodeEngine(EntityEndpointType.FEATURE_GROUP);
 
   @Builder
   public StreamFeatureGroup(FeatureStore featureStore, @NonNull String name, Integer version, String description,
@@ -407,15 +405,13 @@ public Query asOf(String wallclockTime, String excludeUntil) throws FeatureStore
   public void save(Dataset<Row> featureData, Map<String, String> writeOptions)
       throws FeatureStoreException, IOException, ParseException {
     featureGroupEngine.save(this, featureData, partitionKeys, hudiPrecombineKey, writeOptions, null);
-    codeEngine.saveCode(this);
   }
 
   @Deprecated
   public void save(Dataset<Row> featureData, Map<String, String> writeOptions, JobConfiguration jobConfiguration)
       throws FeatureStoreException, IOException, ParseException {
     featureGroupEngine.save(this, featureData, partitionKeys, hudiPrecombineKey, writeOptions,
         jobConfiguration);
-    codeEngine.saveCode(this);
   }
 
   /**
@@ -649,7 +645,6 @@ public void insert(Dataset<Row> featureData, boolean overwrite, Map<String, Stri
                      JobConfiguration jobConfiguration) throws FeatureStoreException, IOException, ParseException {
     featureGroupEngine.insert(this, featureData,  overwrite ? SaveMode.Overwrite : SaveMode.Append,
         partitionKeys, hudiPrecombineKey, writeOptions, jobConfiguration);
-    codeEngine.saveCode(this);
   }
 
   /**

java/spark/src/main/java/com/logicalclocks/hsfs/spark/ExternalFeatureGroup.java

@@ -36,7 +36,6 @@
 import com.logicalclocks.hsfs.TrainingDatasetType;
 import com.logicalclocks.hsfs.constructor.Filter;
 import com.logicalclocks.hsfs.constructor.FilterLogic;
-import com.logicalclocks.hsfs.engine.CodeEngine;
 import com.logicalclocks.hsfs.engine.FeatureGroupUtils;
 import com.logicalclocks.hsfs.metadata.Statistics;
 import lombok.Builder;
@@ -64,7 +63,6 @@ public class TrainingDataset extends TrainingDatasetBase {
 
   private TrainingDatasetEngine trainingDatasetEngine = new TrainingDatasetEngine();
   private StatisticsEngine statisticsEngine = new StatisticsEngine(EntityEndpointType.TRAINING_DATASET);
-  private CodeEngine codeEngine = new CodeEngine(EntityEndpointType.TRAINING_DATASET);
 
   @Builder
   public TrainingDataset(@NonNull String name, Integer version, String description, DataFormat dataFormat,
@@ -122,7 +120,6 @@ public void save(Query query, Map<String, String> writeOptions)
     this.queryInt = query;
     TrainingDataset trainingDataset = trainingDatasetEngine.save(this, this.queryInt, writeOptions, label);
     this.setStorageConnector(trainingDataset.getStorageConnector());
-    codeEngine.saveCode(this);
     computeStatistics();
   }