remove evt time and minor updates

Author: dhananjay-mk

python/hsfs/core/feature_group_engine.py

@@ -106,8 +106,10 @@ def save(
             feature_group.embedding_index, dataframe_features
         )
 
-        if feature_group.online_enabled and validation_options.get(
-            "run_validation", False
+        if (
+            feature_group.online_enabled
+            and not feature_group.embedding_index
+            and validation_options.get("run_validation", False)
         ):
             # validate df schema
             dataframe_features = DataFrameValidator().validate_schema(
@@ -187,8 +189,10 @@ def insert(
             feature_group.embedding_index, dataframe_features
         )
 
-        if feature_group.online_enabled and validation_options.get(
-            "run_validation", False
+        if (
+            feature_group.online_enabled
+            and not feature_group.embedding_index
+            and validation_options.get("run_validation", False)
         ):
             # validate df schema
             dataframe_features = DataFrameValidator().validate_schema(

python/hsfs/core/schema_validation.py

@@ -52,12 +52,6 @@ def validate_schema(self, feature_group, df, df_features):
                 raise ValueError(
                     f"Primary key column {pk} is missing in input dataframe"
                 )
-        # Check if the event time column exists
-        if feature_group.event_time and feature_group.event_time not in df.columns:
-            raise ValueError(
-                f"Event time column {feature_group.event_time} is missing in input dataframe"
-            )
-
         # Execute data type specific validation
         errors, column_lengths, is_pk_null, is_string_length_exceeded = (
             self._validate_df_specifics(feature_group, df, bool(feature_group.id))

python/tests/test_schema_validator.py

@@ -125,17 +125,6 @@ def test_validate_schema_primary_key_missing(self, pandas_df, feature_group_data
                 feature_group_data, pandas_df, feature_group_data.features
             )
 
-    def test_validate_schema_event_time_missing(self, pandas_df, feature_group_data):
-        EVT_TIME = "missing_event_time"
-        feature_group_data.event_time = EVT_TIME
-        with pytest.raises(
-            ValueError,
-            match=f"Event time column {EVT_TIME} is missing in input dataframe",
-        ):
-            DataFrameValidator().validate_schema(
-                feature_group_data, pandas_df, feature_group_data.features
-            )
-
     def test_validate_schema_primary_key_null(self, pandas_df, feature_group_data):
         pandas_df.loc[0, "primary_key"] = None
         with pytest.raises(