Skip to content

Commit ccabb28

Browse files
authored
[FSTORE-1631] Http client shows warnings when response contains cookies (#423)
1 parent 0e335df commit ccabb28

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

java/hsfs/src/main/java/com/logicalclocks/hsfs/metadata/HopsworksExternalClient.java

+3
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import org.apache.http.HttpHost;
3030
import org.apache.http.HttpRequest;
3131
import org.apache.http.client.ResponseHandler;
32+
import org.apache.http.client.config.CookieSpecs;
33+
import org.apache.http.client.config.RequestConfig;
3234
import org.apache.http.config.Registry;
3335
import org.apache.http.config.RegistryBuilder;
3436
import org.apache.http.conn.socket.ConnectionSocketFactory;
@@ -113,6 +115,7 @@ public HopsworksExternalClient(CloseableHttpClient httpClient, HttpHost httpHost
113115
httpClient = HttpClients.custom()
114116
.setConnectionManager(connectionPool)
115117
.setKeepAliveStrategy((httpResponse, httpContext) -> 30 * 1000)
118+
.setDefaultRequestConfig(RequestConfig.custom().setCookieSpec(CookieSpecs.STANDARD).build())
116119
.build();
117120

118121
if (!Strings.isNullOrEmpty(apiKeyValue)) {

java/hsfs/src/main/java/com/logicalclocks/hsfs/metadata/HopsworksInternalClient.java

+3
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
import org.apache.http.HttpHost;
2626
import org.apache.http.HttpRequest;
2727
import org.apache.http.client.ResponseHandler;
28+
import org.apache.http.client.config.CookieSpecs;
29+
import org.apache.http.client.config.RequestConfig;
2830
import org.apache.http.config.Registry;
2931
import org.apache.http.config.RegistryBuilder;
3032
import org.apache.http.conn.socket.ConnectionSocketFactory;
@@ -103,6 +105,7 @@ public HopsworksInternalClient() throws IOException, KeyStoreException, Certific
103105
httpClient = HttpClients.custom()
104106
.setConnectionManager(connectionPool)
105107
.setKeepAliveStrategy((httpResponse, httpContext) -> 30 * 1000)
108+
.setDefaultRequestConfig(RequestConfig.custom().setCookieSpec(CookieSpecs.STANDARD).build())
106109
.build();
107110

108111
certKey = HopsworksHttpClient.readCertKey(MATERIAL_PASSWD);

0 commit comments

Comments
 (0)