Skip to content

Commit f44cbca

Browse files
make required keys mandatory (#319)
Co-authored-by: DhananjayMukhedkar <dhananjay1098@gmail.com>
1 parent a5c28e7 commit f44cbca

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

python/hsfs/core/vector_server.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -556,8 +556,7 @@ def assemble_feature_vector(
556556
"1. There is no match in the given entry."
557557
" Please check if the entry exists in the online feature store"
558558
" or provide the feature as passed_feature. "
559-
f"2. Required entries [{', '.join(self.required_serving_keys)}] or "
560-
f"[{', '.join(set(sk.feature_name for sk in self._serving_keys))}] are not provided."
559+
f"2. Required entries [{', '.join(self.required_serving_keys)}] are not provided."
561560
)
562561

563562
if len(self.return_feature_value_handlers) > 0:
@@ -1476,7 +1475,6 @@ def valid_serving_keys(self):
14761475
if not self._valid_serving_keys or len(self._valid_serving_keys) == 0:
14771476
self._valid_serving_keys = set(
14781477
[sk.required_serving_key for sk in self.serving_keys]
1479-
+ [sk.feature_name for sk in self.serving_keys]
14801478
)
14811479
return self._valid_serving_keys
14821480

0 commit comments

Comments
 (0)