[FSTORE-1320] Fix hopsworks.login second attempt not taking parameters into account #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both adding client.stop in logout and in connect method of connection are sufficient to fix the issue. It does feel like both make sense to have though |
robzor92
approved these changes
Mar 22, 2024
vatj
added a commit
to vatj/hopsworks-api
that referenced
this pull request
Apr 5, 2024
…s into account (logicalclocks#192) * Cleanup client irrespective of whether connection was set * Reset client in connection before initialising it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup client irrespective of whether connection was set properly