Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1480] Deduplicate git* #246

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Jul 25, 2024

Requires #220 and #245 to be merged first.

JIRA Issue: FSTORE-1480

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey self-assigned this Jul 25, 2024
Copy link
Collaborator

@robzor92 robzor92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the github mkdocs action is failing

@aversey
Copy link
Contributor Author

aversey commented Jul 29, 2024

Also the github mkdocs action is failing

It was, since this PR depends on the previous ones. Now that they are merged, the mkdocs error will go away too.

@aversey aversey merged commit b510e30 into logicalclocks:main Jul 29, 2024
13 checks passed
@aversey aversey deleted the dedup-git branch August 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants