Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1452] Deduplicate job- and execution-related code #247

Merged
merged 22 commits into from
Aug 13, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Jul 29, 2024

JIRA Issue: FSTORE-1452

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey self-assigned this Jul 30, 2024
@aversey aversey requested a review from robzor92 July 31, 2024 13:22
@aversey aversey force-pushed the dedup-job-execution branch from 8febe83 to c10fccf Compare August 2, 2024 09:17
@vatj vatj self-requested a review August 5, 2024 09:55
@aversey aversey requested a review from vatj August 12, 2024 14:21
@aversey aversey merged commit 7291f86 into logicalclocks:main Aug 13, 2024
4 checks passed
@aversey aversey deleted the dedup-job-execution branch August 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants