Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1489] make prefix in required serving key mandatory #319

Merged
merged 4 commits into from
Oct 7, 2024
Merged

[FSTORE-1489] make prefix in required serving key mandatory #319

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
659d8d6
make required keys mandatory
dhananjay-mk Aug 23, 2024
d15f1ed
Merge branch 'logicalclocks:main' into prefix-msg
aversey Sep 9, 2024
c45e315
Merge remote-tracking branch 'origin/main' into prefix-msg
aversey Oct 1, 2024
eb7c05c
Merge remote-tracking branch 'origin/main' into prefix-msg
aversey Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions python/hsfs/core/vector_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,8 +550,7 @@ def assemble_feature_vector(
"1. There is no match in the given entry."
" Please check if the entry exists in the online feature store"
" or provide the feature as passed_feature. "
f"2. Required entries [{', '.join(self.required_serving_keys)}] or "
f"[{', '.join(set(sk.feature_name for sk in self._serving_keys))}] are not provided."
f"2. Required entries [{', '.join(self.required_serving_keys)}] are not provided."
)

if len(self.return_feature_value_handlers) > 0:
Expand Down Expand Up @@ -1465,7 +1464,6 @@ def valid_serving_keys(self):
if not self._valid_serving_keys or len(self._valid_serving_keys) == 0:
self._valid_serving_keys = set(
[sk.required_serving_key for sk in self.serving_keys]
+ [sk.feature_name for sk in self.serving_keys]
)
return self._valid_serving_keys

Expand Down
Loading