Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1522] Deduplicate most of hsml #322

Merged
merged 20 commits into from
Oct 7, 2024
Merged

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Sep 10, 2024

The only thing left is explicit_provenance, which is to be deduplicated in a separate PR.

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey requested a review from vatj September 10, 2024 05:40
@aversey aversey self-assigned this Sep 10, 2024
@aversey
Copy link
Contributor Author

aversey commented Sep 10, 2024

I have tried it out with loadtest/tests/workflows/model_registry/test_export.py, the test have passed successfully.

@aversey aversey changed the base branch from main to dev October 7, 2024 12:42
@aversey aversey merged commit 021ba7d into logicalclocks:dev Oct 7, 2024
13 checks passed
@aversey aversey deleted the dedup-hsml branch October 22, 2024 08:11
@aversey aversey restored the dedup-hsml branch October 22, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant