[FSTORE-1630] Model Dependent Transformation Functions creates feature names that are longer than 64 character causing logging feature group ingestion to fail #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubriks
requested changes
Jan 27, 2025
bubriks
approved these changes
Jan 27, 2025
…ransformation functions
…ing to solve the problem by manually slicing the column names
manu-sj
added a commit
to manu-sj/hopsworks-api
that referenced
this pull request
Jan 28, 2025
…e names that are longer than 64 character causing logging feature group ingestion to fail (logicalclocks#428) * adding alias function to modify output column names * adding unit tests * fixing generation of output column names when udf is shared between transformation functions * updating documentation * converting error caused due to long column names to a warning and trying to solve the problem by manually slicing the column names * adding tests for creation of stripped column names * correcting documentation mistake and making test self contained
manu-sj
added a commit
to manu-sj/hopsworks-api
that referenced
this pull request
Jan 29, 2025
…e names that are longer than 64 character causing logging feature group ingestion to fail (logicalclocks#428) * adding alias function to modify output column names * adding unit tests * fixing generation of output column names when udf is shared between transformation functions * updating documentation * converting error caused due to long column names to a warning and trying to solve the problem by manually slicing the column names * adding tests for creation of stripped column names * correcting documentation mistake and making test self contained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
aliasfunction to transformation function that can be used to specify output column names for the transformation functions.JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1630
Priority for Review: -
Related PRs:
https://github.com/logicalclocks/hopsworks-ee/pull/2168
https://github.com/logicalclocks/loadtest/pull/493
logicalclocks/logicalclocks.github.io#429
https://github.com/logicalclocks/hopsworks-front/pull/1403
How Has This Been Tested?
Checklist For The Assigned Reviewer: