Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HWORKS-2064] Auto-increment model export only looks at the model version folder, should also account for model version db metadata #503

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

robzor92
Copy link
Collaborator

@robzor92 robzor92 commented Mar 6, 2025

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@robzor92 robzor92 requested a review from javierdlrm March 6, 2025 13:28
@javierdlrm javierdlrm self-requested a review March 6, 2025 16:12
@robzor92 robzor92 enabled auto-merge (squash) March 6, 2025 16:21
@robzor92 robzor92 merged commit 55a0853 into logicalclocks:main Mar 6, 2025
14 of 15 checks passed
robzor92 added a commit to robzor92/hopsworks-api that referenced this pull request Mar 7, 2025
…sion folder, should also account for model version db metadata (logicalclocks#503)
robzor92 added a commit that referenced this pull request Mar 7, 2025
…sion folder, should also account for model version db metadata (#503) (#504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants