Skip to content

Commit 8d1964d

Browse files
committed
[HWORKS-934] Use more precise statistics (#1681)
1 parent a2e2529 commit 8d1964d

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

hopsworks-api/src/main/java/io/hops/hopsworks/api/featurestore/statistics/FeatureDescriptiveStatisticsBuilder.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -134,21 +134,21 @@ public FeatureDescriptiveStatistics buildFromDeequJson(JSONObject statsJson) {
134134
fds.setCount(statsJson.getLong("count"));
135135
}
136136
if (statsJson.has("completeness")) {
137-
fds.setCompleteness(statsJson.getDouble("completeness"));
137+
fds.setCompleteness(Float.valueOf(statsJson.getString("completeness")));
138138
}
139139
if (statsJson.has("approximateNumDistinctValues")) {
140140
fds.setApproxNumDistinctValues(statsJson.getLong("approximateNumDistinctValues"));
141141
}
142142

143143
// commmon for all data types if exact_uniqueness is enabled
144144
if (statsJson.has("uniqueness")) {
145-
fds.setUniqueness(statsJson.getDouble("uniqueness"));
145+
fds.setUniqueness(Float.valueOf(statsJson.getString("uniqueness")));
146146
}
147147
if (statsJson.has("entropy")) {
148-
fds.setEntropy(statsJson.getDouble("entropy"));
148+
fds.setEntropy(Float.valueOf(statsJson.getString("entropy")));
149149
}
150150
if (statsJson.has("distinctness")) {
151-
fds.setDistinctness(statsJson.getDouble("distinctness"));
151+
fds.setDistinctness(Float.valueOf(statsJson.getString("distinctness")));
152152
}
153153
if (statsJson.has("exactNumDistinctValues")) {
154154
fds.setExactNumDistinctValues(statsJson.getLong("exactNumDistinctValues"));

hopsworks-common/src/main/java/io/hops/hopsworks/common/featurestore/statistics/FeatureDescriptiveStatisticsDTO.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class FeatureDescriptiveStatisticsDTO extends RestDTO<FeatureDescriptiveS
3333

3434
// for any feature type
3535
private Long count;
36-
private Double completeness;
36+
private Float completeness;
3737
private Long numNonNullValues;
3838
private Long numNullValues;
3939
private Long approxNumDistinctValues;
@@ -47,9 +47,9 @@ public class FeatureDescriptiveStatisticsDTO extends RestDTO<FeatureDescriptiveS
4747
private List<Double> percentiles;
4848

4949
// with exact uniqueness
50-
private Double distinctness;
51-
private Double entropy;
52-
private Double uniqueness;
50+
private Float distinctness;
51+
private Float entropy;
52+
private Float uniqueness;
5353
private Long exactNumDistinctValues;
5454

5555
// histogram, correlations, kll <- from hdfs file

hopsworks-persistence/src/main/java/io/hops/hopsworks/persistence/entity/featurestore/statistics/FeatureDescriptiveStatistics.java

+12-12
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public class FeatureDescriptiveStatistics implements Serializable {
6666

6767
@Basic
6868
@Column(name = "completeness")
69-
private Double completeness;
69+
private Float completeness;
7070

7171
@Basic
7272
@Column(name = "num_non_null_values")
@@ -111,15 +111,15 @@ public class FeatureDescriptiveStatistics implements Serializable {
111111

112112
@Basic
113113
@Column(name = "distinctness")
114-
private Double distinctness;
114+
private Float distinctness;
115115

116116
@Basic
117117
@Column(name = "entropy")
118-
private Double entropy;
118+
private Float entropy;
119119

120120
@Basic
121121
@Column(name = "uniqueness")
122-
private Double uniqueness;
122+
private Float uniqueness;
123123

124124
@Basic
125125
@Column(name = "exact_num_distinct_values")
@@ -213,11 +213,11 @@ public void setPercentiles(List<Double> percentiles) {
213213
this.percentiles = percentiles;
214214
}
215215

216-
public Double getCompleteness() {
216+
public Float getCompleteness() {
217217
return completeness;
218218
}
219219

220-
public void setCompleteness(Double completeness) {
220+
public void setCompleteness(Float completeness) {
221221
this.completeness = completeness;
222222
}
223223

@@ -237,27 +237,27 @@ public void setNumNullValues(Long numNullValues) {
237237
this.numNullValues = numNullValues;
238238
}
239239

240-
public Double getDistinctness() {
240+
public Float getDistinctness() {
241241
return distinctness;
242242
}
243243

244-
public void setDistinctness(Double distinctness) {
244+
public void setDistinctness(Float distinctness) {
245245
this.distinctness = distinctness;
246246
}
247247

248-
public Double getEntropy() {
248+
public Float getEntropy() {
249249
return entropy;
250250
}
251251

252-
public void setEntropy(Double entropy) {
252+
public void setEntropy(Float entropy) {
253253
this.entropy = entropy;
254254
}
255255

256-
public Double getUniqueness() {
256+
public Float getUniqueness() {
257257
return uniqueness;
258258
}
259259

260-
public void setUniqueness(Double uniqueness) {
260+
public void setUniqueness(Float uniqueness) {
261261
this.uniqueness = uniqueness;
262262
}
263263

0 commit comments

Comments
 (0)